Mainly DaqController Stuff #76
Conversation
| end | ||
| end | ||
|
|
||
| % what are these lines doing? why outputSingleScan? why a/d separate? |
There was a problem hiding this comment.
It's important to output the default value for instance if you wanted a channel that was always high and occasionally went low, or an analogue channel with a baseline voltage. Why were lines 94-97 removed?
There was a problem hiding this comment.
b/c I have it in later (line 121)
| end | ||
| end | ||
| end | ||
|
|
||
| function clearSessions(obj) |
There was a problem hiding this comment.
Although this is fine for debugging, it's probably not worth keeping in the code. Instead, you could have the createDaqChannels method check whether a channel of that name as already been added before attempting to add one.
| @@ -105,12 +130,14 @@ function command(obj, varargin) | |||
| % Sends command signals to each channel | |||
| % | |||
| % command(channels, values) | |||
| outputSingleScan(obj.DaqSession, v(obj.AnalogueChannelsIdx)); | ||
| if any(obj.AnalogueChannelsIdx) | ||
| outputSingleScan(obj.DaqSession, v(obj.AnalogueChannelsIdx)); | ||
| end | ||
| if any(~obj.AnalogueChannelsIdx) | ||
| outputSingleScan(obj.DigitalDaqSession, v(~obj.AnalogueChannelsIdx)); |
There was a problem hiding this comment.
Can you outputSingleScan on a clocked channel? Same for line 253
There was a problem hiding this comment.
I think you want to set a different property or something for a clocked session...
There was a problem hiding this comment.
yes, outputSingleScan does work for counter channels
| end | ||
| readyWait(obj); | ||
| %readyWait(obj); |
There was a problem hiding this comment.
What was your rational for removing readywait?
There was a problem hiding this comment.
we have a readyWait in the command function immediately following queue, so this becomes redundant
| @@ -604,7 +604,8 @@ function livePlot(obj, data) | |||
| % TL.LIVEPLOT(source, event) plots the data aquired by the | |||
| % DAQ while the PlotLive property is true. | |||
| if isempty(obj.Axes) | |||
| f = figure('Units', 'Normalized', 'Position', [0 0 1 1]); % create a figure for plotting aquired data | |||
There was a problem hiding this comment.
I'd leave this in as all timeline computers run solely for that purpose and usually there are many inputs being acquired so more often than not the experimenter would want it to be full screen
There was a problem hiding this comment.
but this allows for optionality? can still make figure full screen
|
Double check that the signals and alyx-matlab submodules are all on the latest cortex-lab dev branch. If you've made any changes to them submit to a separate pull request for them |
No description provided.