Dev git update #78
Merged
Dev git update #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1o0
requested changes
Dec 7, 2018
cortexlab/+git/update.m
Outdated
| end | ||
| gitexepath = ['"', strtrim(gitexepath), '"']; | ||
|
|
||
| % Temporarily change directory into Rigbox | ||
| % Temporarily change directory into Rigbox -> isn't it safe to assume we're | ||
| % already in Rigbox? (since we're running this file, presumably we are?) |
There was a problem hiding this comment.
It isn't safe to assume this. All Rigbox functions are in the paths so there's no need to be in the Rigbox folder in order to run them. The code has been carefully set up so that everything runs regardless of working directory. This is important as users often want to run Rigbox in conjunction with local functions that aren't on the paths. If you're happy with this you can remove this comment push
There was a problem hiding this comment.
Oh and the reason I cd here is because pulling from outside the git repo wasn't working for me. Not sure why
jkbhagatio
commented
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.