Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveform extraction datasets #853

Merged
merged 5 commits into from
May 3, 2024
Merged

Waveform extraction datasets #853

merged 5 commits into from
May 3, 2024

Conversation

chris-langfield
Copy link
Collaborator

No description provided.

juhuntenburg and others added 4 commits April 24, 2024 17:52
@juhuntenburg
Merge pull request #852 from cortex-lab/dev
a85c8b0 
Adding filename pattern for Lightning Pose dataset type
wf extract dsets
b0ed7f6
npz
c702e7f
comma
cdb97ce
@chris-langfield chris-langfield requested a review from k1o0 May 2, 2024 22:46
k1o0
k1o0 reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the dataset types should be format agnostic, so it's better to say 'table' instead of 'pandas DataFrame'.

@chris-langfield
Copy link
Collaborator Author

makes sense thanks!

@chris-langfield chris-langfield merged commit 8392bf5 into dev May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1o0 k1o0 k1o0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-langfield @k1o0 @juhuntenburg