Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only rebuild those affected entries #518

Merged
merged 3 commits into from
Feb 28, 2016

Conversation

chinesedfan
Copy link
Contributor

As #514 describes,

Add another build type, like mod. It may require neuron-builder to accept the changed file as an argument. So that it can reject unnecessary build. If users only modify a file in mod/, entries that do not depend on it will not be re-built.

This MR depends on another MR in cortex-neuron-builder project.

And I have to admit that function isMod is too rude. If reading from somewhere in cortex.json, say field mods, will be more flexible. But it may lead to a series of modifications.

@chinesedfan chinesedfan reopened this Feb 28, 2016
kaelzhang pushed a commit that referenced this pull request Feb 28, 2016
only rebuild those affected entries
@kaelzhang kaelzhang merged commit 37aef9a into cortexjs-legacy:master Feb 28, 2016
@chinesedfan chinesedfan deleted the mod branch March 18, 2016 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants