Introduce faillint in the CI workflow #2272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
A common mistake (I did it too) is to import
github.com/bmizerany/assert
instead ofgithub.com/stretchr/testify/assert
. In this PR I've introducedfaillint
as further lint step to ensure no blacklisted package is imported. Of you try to usegithub.com/bmizerany/assert
the linter will fail, suggesting which package should be used instead:faillint
will also be useful in the future to enforce some design patterns (ie. once completed the Prometheus metrics refactoring, we'll be able to forbid the usage ofprometheus.NewGauge()
in favor ofpromauth.With(reg).NewGauge()
and so on).Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]