Add K8s.Client.Runner.Watch.stream/3 to return watch events as stream #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this is very cool. I'm going to cut some time out of Friday afternoon to review in more depth. |
mruoss
commented
Oct 13, 2021
|
Hey @coryodaniel did you have the chance to look at this? |
|
Not yet. Have time set on my cal to look this Friday.
On Tue, Nov 2, 2021 at 3:02 PM Michael Ruoss ***@***.***> wrote:
Hey @coryodaniel <https://github.com/coryodaniel> did you have the chance
to look at this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAC2QZSQOFWMZVKESRMUB3UKBNYFANCNFSM5F3LZHGQ>
.
--
Cory ODaniel
Mobile: 310.606.0257
***@***.***
medium: @coryodaniel ***@***.***>
twitter: @coryodaniel <https://twitter.com/coryodaniel>
|
jlgeering
reviewed
Jan 31, 2022
jlgeering
reviewed
Jan 31, 2022
added 7 commits
January 31, 2022 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to solve #10. In my opinion, the watcher should return a stream of events. That's what this modules does. The code is inspired by bonny's watcher but solves some things a bit differently (e.g. transforming chunks to lines to events).
This time I've tested it on my local cluster.
What do you think?