feat: implement controller runtime gRPC bridge #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
runtime-service
branch
2 times, most recently
from
f71899e
to
06d6b9d
Compare
Wrap controller runtime into gRPC server following same model as for the state. One method can't be wrapped easily (`Modify`) so it was skipped. Runtime adapter was extended with two new methods: `Create` and `Update` which follow same semantics as resource state API. Breaking (but easy) change: method `controller.Runtime.Update` was renamed to `Modify` to avoid confusion with state `Update` method. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
|
/approve |
andrewrynhard
approved these changes
Mar 22, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap controller runtime into gRPC server following same model as for the
state. One method can't be wrapped easily (
Modify) so it was skipped.Runtime adapter was extended with two new methods:
CreateandUpdatewhich follow same semantics as resource state API.
Breaking (but easy) change: method
controller.Runtime.Updatewasrenamed to
Modifyto avoid confusion with stateUpdatemethod.Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com