feat: add flag to listen on TCP #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrynhard
commented
Apr 23, 2021
invidian
reviewed
Apr 23, 2021
cmd/runtime/main.go
Outdated
| @@ -26,10 +27,12 @@ import ( | |||
| "github.com/cosi-project/runtime/pkg/state/protobuf/server" | |||
| ) | |||
|
|
|||
| var addressAndPort string | |||
There was a problem hiding this comment.
Was already the pattern used. I just went with it.
There was a problem hiding this comment.
Happy to address in a follow up, unless we feel it should be addressed in this PR.
andrewrynhard
force-pushed
the
socket
branch
3 times, most recently
from
22638fa
to
51c7d25
Compare
|
|
smira
reviewed
Apr 23, 2021
| proto "github.com/golang/protobuf/proto" | ||
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| reflect "reflect" |
There was a problem hiding this comment.
not sure why these changes popped up?
andrewrynhard
force-pushed
the
socket
branch
2 times, most recently
from
0768496
to
4ac518b
Compare
andrewrynhard
commented
Apr 23, 2021
Adds a flag for setting the address and port to bind to. TCP is the default, but if a socket path is specified that will be used instead. Signed-off-by: Andrew Rynhard <andrew@rynhard.io>
smira
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Rynhard andrew@rynhard.io