Fix duplication in FCM message.Added new integration test. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogh
approved these changes
Apr 7, 2017
bogh
approved these changes
Apr 7, 2017
|
build failed |
cosminrentea
reviewed
Apr 7, 2017
| @@ -48,7 +48,7 @@ func fcmMessage(message *protocol.Message) *gcm.Message { | |||
| "messageID": message.ID, | |||
| "correlation_id": message.CorrelationID(), | |||
| }).Error("Could not decode fcm.Message from guble message body") | |||
| } else if m.Notification != nil && m.Data != nil { | |||
| } else if m.Data != nil { | |||
cosminrentea
approved these changes
Apr 7, 2017
|
triggered a rebuild |
added 7 commits
April 7, 2017 16:21
… fix/set-last-id-failure
…ntea/gobbler into fix/set-last-id-failure
bogh
reviewed
Apr 10, 2017
server/fcm_integration_test.go
Outdated
| @@ -55,6 +55,10 @@ type expectedValues struct { | |||
|
|
|||
| // Test that restarting the service continues to fetch messages from store for a subscription from lastID | |||
| func TestFCMRestart(t *testing.T) { | |||
|
|
|||
| defer testutil.SkipIfDisabled(t) | |||
| defer testutil.SkipIfShort(t) | |||
bogh
approved these changes
Apr 10, 2017
bogh
approved these changes
Apr 10, 2017
bogh
approved these changes
Apr 10, 2017
added 3 commits
April 12, 2017 11:05
… fix/set-last-id-failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PN-358