Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix controller bugs #730

Merged
merged 2 commits into from
May 31, 2023
Merged

fix controller bugs #730

merged 2 commits into from
May 31, 2023

Conversation

jlandowner
Copy link
Member

@jlandowner jlandowner commented May 31, 2023 •
edited
Loading

close #724
close #729

improve tests

@jlandowner jlandowner added bug Something isn't working controller-manager Controller Manager go Pull requests that update Go code labels May 31, 2023
@jlandowner jlandowner requested a review from oruharo May 31, 2023 15:15
@oruharo oruharo merged commit 4bed7ae into cosmo-workspace:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruharo oruharo Awaiting requested review from oruharo

Assignees
No one assigned
Labels
bug Something isn't working controller-manager Controller Manager go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User.Status.Addons are empty Namespaced resources in ClusterInstance is not deleted in GC
2 participants
@jlandowner @oruharo