Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Explorer: Backend Support #54

Merged
merged 31 commits into from
Jan 24, 2021
Merged

Node Explorer: Backend Support #54

merged 31 commits into from
Jan 24, 2021

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 13, 2021

Add support for node exploration and crawling in Atlas:

  • Port crawling functionality from tmcrawl
  • Add DB models & schema migrations
  • Add API route to search for nodes
  • Tests

ref: #53

@alexanderbez alexanderbez changed the title Node Explorer Node Explorer: Backend Support Jan 23, 2021
@alexanderbez alexanderbez self-assigned this Jan 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2021

This pull request introduces 2 alerts when merging 08c02f5 into 2de14cc - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types
  • 1 for Database query built from user-controlled sources

@alexanderbez alexanderbez marked this pull request as ready for review January 23, 2021 22:44
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2021

This pull request introduces 2 alerts when merging 81a0f55 into 2de14cc - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types
  • 1 for Database query built from user-controlled sources

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #54 (c403398) into main (2de14cc) will decrease coverage by 3.72%.
The diff coverage is 41.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   59.34%   55.62%   -3.73%     
==========================================
  Files          18       22       +4     
  Lines        1493     1886     +393     
==========================================
+ Hits          886     1049     +163     
- Misses        469      682     +213     
- Partials      138      155      +17     
Impacted Files Coverage Δ
cmd/server.go 51.13% <0.00%> (-3.75%) ⬇️
server/crawl/node_crawler.go 0.00% <0.00%> (ø)
server/crawl/util.go 0.00% <0.00%> (ø)
server/models/module.go 57.08% <ø> (ø)
server/router/v1/router.go 56.55% <45.45%> (-0.66%) ⬇️
server/models/node.go 74.66% <74.66%> (ø)
server/crawl/pool.go 97.36% <97.36%> (ø)
... and 1 more

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2021

This pull request introduces 2 alerts when merging 2ccbc5e into 2de14cc - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types
  • 1 for Database query built from user-controlled sources

@alexanderbez alexanderbez merged commit e589ad3 into main Jan 24, 2021
@alexanderbez alexanderbez deleted the feature/53-node-explorer branch January 24, 2021 16:13
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2021

This pull request introduces 2 alerts when merging 222cc6c into 2de14cc - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types
  • 1 for Database query built from user-controlled sources


# The initial list of comma-delimited seed nodes to crawl, where each seed takes
# the form of [host]:[port];[chain-id], where ;[chain-id] is optional.
ATLAS_NODE_SEEDS = "http://1.255.51.125:26657;cosmsohub-3,..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to target https://github.com/cosmos/registry eventually and in the future when these get moved to the cosmos name service to query them there (oh shit what a chicken or egg problem tho, need a node to query the node for the list of nodes 🤪)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants