Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Amino JSON conversion for authz+feegrant message types #1092

Open
5 tasks
webmaster128 opened this issue Mar 15, 2022 · 5 comments
Open
5 tasks

Implement Amino JSON conversion for authz+feegrant message types #1092

webmaster128 opened this issue Mar 15, 2022 · 5 comments
Labels
authz cosmos-sdk-0.47-🤟
Milestone
0.33.0

Comments

@webmaster128
Copy link
Member

webmaster128 commented Mar 15, 2022 •
edited
Loading

Right now, the types are marked as not supported on chan (authz messages / feegrant messages). Once Cosmos SDK 0.46 is out, Amino JSON signing for those types can be used and should be implemented.

  • /cosmos.authz.v1beta1.MsgGrant
  • /cosmos.authz.v1beta1.MsgExec
  • /cosmos.authz.v1beta1.MsgRevoke
  • /cosmos.feegrant.v1beta1.MsgGrantAllowance
  • /cosmos.feegrant.v1beta1.MsgRevokeAllowance
@webmaster128 webmaster128 added this to the 0.29.0 milestone Mar 15, 2022
@webmaster128 webmaster128 mentioned this issue Mar 16, 2022
Closed
@webmaster128 webmaster128 changed the title Implement Amino JSON conversion for authz+feegrant types Implement Amino JSON conversion for authz+feegrant message types Jun 29, 2022
@webmaster128
Copy link
Member Author

Removing from milestone to not block release on it

@webmaster128 webmaster128 removed this from the 0.29.0 milestone Aug 18, 2022
@webmaster128 webmaster128 mentioned this issue Sep 15, 2022
Closed
@assafmo
Copy link
Contributor

assafmo commented Sep 16, 2022

For reference, this is working & tested: https://github.com/scrtlabs/secret.js/blob/cosmwasm-v1/src/tx/feegrant.ts

You also need to add granter?: string to StdFee.

@webmaster128
Copy link
Member Author

Thank you @assafmo!

The granter was added to StdFee in #1262 which is shipped with 0.29.0. The PR also contains a feegrant test. But without Amino support.

@webmaster128 webmaster128 added this to the 0.31.0 milestone Jun 13, 2023
@webmaster128 webmaster128 modified the milestones: 0.31.0, 0.32.0 Jun 13, 2023
@williamchong
Copy link

williamchong commented Jun 27, 2023 •
edited
Loading

We have implemented a working amino convertor for authz for our 0.46 sdk chain
likecoin/iscn-js@1ac7fb6
Will PR if this seems useful

@webmaster128
Copy link
Member Author

That's useful, thank you!

@webmaster128 webmaster128 modified the milestones: 0.32.0, 0.33.0 Nov 7, 2023
@avkr003 avkr003 mentioned this issue Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
authz cosmos-sdk-0.47-🤟
Projects
None yet
Milestone
0.33.0
Development

No branches or pull requests
3 participants
@webmaster128 @williamchong @assafmo