-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove go.mod replace
line for gin-gonic/gin
#10409
Comments
Hi @AmauryM, could you assign this issue to me? I'm looking for contribute on Go projects repos and (my main objective) blockchain projects. I would love to help and continually contribute on this repo. |
Sure! Make sure to double check that all cosmos deps that import gin-gonic/gin, actually already updated their gin-gonic/gin dep to >=1.7.0. Feel free to create a PR anytime. |
Ref: coder/websocket#332 (looks unmaintained 😢 )
|
Any thoughts regarding the use of a fork that is maintained? coder/websocket#332 (comment) |
This and gogo protobuf are the only blockers for regen to use |
isn't this issue now closed? I just checked through things, and we're only referencing the old version in the submodules that import v0.46.1. We might be able to cure this -- if the goal is to use go install (it is a great goal) -- by using https://github.com/notional-labs/websocket or coder/websocket#332 (comment) in v0.46.2 I am not sure about gogo/protobuf; I expect that'll be a good deal harder. |
Summary of Refactor
Remove this line
cosmos-sdk/go.mod
Line 132 in 5b1a14c
Version
After #10401
Proposal
For Admin Use
The text was updated successfully, but these errors were encountered: