Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEXTUAL Value Renderers for bytes #12711

Closed
2 tasks
amaury1093 opened this issue Jul 25, 2022 · 0 comments · Fixed by #12734
Closed
2 tasks

TEXTUAL Value Renderers for bytes #12711

amaury1093 opened this issue Jul 25, 2022 · 0 comments · Fixed by #12734
Assignees
@joeabbey

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jul 25, 2022 •
edited

Part of #11970

Add value renderers for bytes, as defined in ADR-050. Only the Format method is needed for now, the Parse one can be left for later.

  • Implementation
  • Use shared test vectors with CosmJS (TODO Ask Simon to generate test vectors)
@amaury1093 amaury1093 mentioned this issue Jul 25, 2022
Closed
39 tasks
@joeabbey joeabbey mentioned this issue Jul 26, 2022
Merged
19 tasks
joeabbey added a commit that referenced this issue Jul 26, 2022
@joeabbey
feat(textual): bytes value renderers #12711
be6620d
mergify bot pushed a commit that referenced this issue Jul 27, 2022
@joeabbey
feat(textual): bytes value renderer (#12734)
3343c57 
## Description

Closes: #12711

Implements bytes value renderer for SIGN_MODE_TEXTUAL

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@mergify mergify bot closed this as completed in #12734 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeabbey joeabbey

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(textual): bytes value renderer cosmos/cosmos-sdk
2 participants
@joeabbey @amaury1093