fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. #13610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpicyLemon
changed the title
SpicyLemon
changed the title
tac0turtle
approved these changes
Oct 21, 2022
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Oct 24, 2022
* fix: move ics23 to correct folder (cosmos#13549) * fix: fix liveness tests cosmos#13551 * feat: add `GenSignedMockTx` (cosmos#13557) * fix: fix `make proto-gen` (cosmos#13564) * fix: fix `make proto-gen` * add changelog * feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589) * chore: bump tendermint to `0.34.22` (cosmos#13585) * fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588) * fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog. * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # proto/cosmos/auth/v1beta1/query.proto # tests/e2e/auth/suite.go # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/auth/types/query.pb.gw.go * update changelog * fix conflicts Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare 0.45.10 changelog (cosmos#13624) * chore: prepare 0.45.10 changelog * default release notes * period * Add missing changelog section for v0.45.9-pio-1. * Remove the old release notes. * Remove accidentally duplicated section for v0.45.4. * Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff. * Include a 'nothing' under unreleased. * Add links to changlog entries. Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
jaybxyz
pushed a commit
to cosmosquad-labs/cosmos-sdk
that referenced
this pull request
Nov 1, 2022
…tConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog. (cherry picked from commit 3f29739)
nnkken
pushed a commit
to likecoin/cosmos-sdk
that referenced
this pull request
Nov 16, 2022
…tConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog.
drklee3
pushed a commit
to Kava-Labs/cosmos-sdk
that referenced
this pull request
Feb 16, 2023
…tConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds back in, the setting of the
PruningKeepEveryconfig field inGetConfig.When #13321 was backported to v0.45.x (#13338), it accidentally carried with it a change to the server config's
GetConfigfunction that removed the setting of thePruningKeepEveryfield. That field has been removed inmainandrelease/v0.46.x, but still exists inrelease/v0.45.x.This PR is targeting
release/v0.45.xbecause it is only applicable there.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change