Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gov): move args in gov new proposal constructor #14782

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

As discussed, it makes more sense to have the 3 strings next to each other (after the addition of title and summary).
As I am doing this for v0.48 here: #14720, it makes sense to do that already for v0.47. So the API break is minimum for v0.48 afterward.

Note: in the backported PR to v0.47.x, we have to cherry-pick the proposer migration from https://github.com/cosmos/cosmos-sdk/pull/13010/files#diff-84dd4933b673594c4303f0a35d9cd93810c49b39a25779abaeb326ebbc34f02fR14.
ref: https://github.com/cosmos/cosmos-sdk/pull/13010/files#r1059373460


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jan 25, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner January 25, 2023 14:43
@github-prbot github-prbot requested review from a team, amaury1093 and testinginprod and removed request for a team January 25, 2023 14:45
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt merged commit 2b64d74 into main Jan 25, 2023
@julienrbrt julienrbrt deleted the julien/gov branch January 25, 2023 17:34
mergify bot pushed a commit that referenced this pull request Jan 25, 2023
(cherry picked from commit 2b64d74)

# Conflicts:
#	CHANGELOG.md
#	x/gov/simulation/operations_test.go
alexanderbez pushed a commit that referenced this pull request Jan 25, 2023
…ser migration (backport #14782) (#14785)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:Simulations C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants