fix: StateSync Restore by excluding memory store #16449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
kocubinski and
atheeshp
and removed request for
a team
julienrbrt
added
backport/v0.47.x
julienrbrt
changed the title
chillyvee
force-pushed
the
cv_fix_ssync_commit
branch
from
f01057a
to
f90fe9e
Compare
julienrbrt
approved these changes
Jun 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit d1e685b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit d1e685b) # Conflicts: # CHANGELOG.md
julienrbrt
pushed a commit
that referenced
this pull request
Jun 7, 2023
julienrbrt
added a commit
that referenced
this pull request
Jun 7, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…) (cosmos#16452) Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha
pushed a commit
to InjectiveLabs/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
…) (cosmos#16452) Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StateSync restore over p2p network and the new v0.47 local snapshot BOTH FAIL after restore due to AppHash mismatch.
Exclude
memory:capabilitystore to follow logic in commitStores()Reference for proper commit info building:
https://github.com/cosmos/cosmos-sdk/blob/main/store/rootmulti/store.go#L1176
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change