Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ADR 026 #7029

Merged
merged 63 commits into from
Sep 4, 2020
Merged

Implement ADR 026 #7029

merged 63 commits into from
Sep 4, 2020

Commits on Aug 12, 2020

  1. Add allow_governance_override_after_expiry flag to tendermint NewCrea… 

    …teClientCmd
    @dauTT
    dauTT committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    0b2ca3a View commit details
    Browse the repository at this point in the history

  2. 1) Add LatestTimestamp to ClientState struct by adding a new attribut… 

    …e latest_timestamp to the message ClientState in proto/ibc/tendermint/tendermint.proto

2) Autogenerate x/ibc/07-tendermint/types/tendermint.pb.go by running 'make proto-gen'. Strangely, as a side effect x/distribution/types/genesis.pb.go, x/evidence/types/genesis.pb.go were also modified by the command 'make proto-gen'
3) Add Expired() function
    @dauTT
    dauTT committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7eb83d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Fix tests

    @dauTT
    dauTT committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    4e131a5 View commit details
    Browse the repository at this point in the history

  2. 1) Add allow_governance_override_after_expiry flag to tendemint clien… 

    …tStatus

2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus
    @dauTT
    dauTT committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    54e2c10 View commit details
    Browse the repository at this point in the history

  3. Cosmetic changes

    @dauTT
    dauTT committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    46753bc View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @dauTT
    dauTT committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    bbaf594 View commit details
    Browse the repository at this point in the history

  5. Add Unfreeze function

    @dauTT
    dauTT committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0ec9447 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. Add new ClientUpdateProposal type

    @dauTT
    dauTT committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    11e5545 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. Add minor fixes

    @dauTT
    dauTT committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    7725884 View commit details
    Browse the repository at this point in the history

  2. Add NewClientUpdateProposalHandler unit tests

    @dauTT
    dauTT committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    024c7a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dauTT/ADR-26-issue-6998

    @dauTT
    dauTT committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    4c7331e View commit details
    Browse the repository at this point in the history

  4. Fix proto-lint-docker

    @dauTT
    dauTT committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    2481b5e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Delete x/ibc/07-tendermint/tendermint_test.go

    @dauTT
    dauTT committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    ec39812 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Follow convention to put signer last in msg function signature

    @dauTT
    dauTT committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    449f7b6 View commit details
    Browse the repository at this point in the history

  2. 1) Add GetLatestTimestamp function to ClientStatus interface 

    2) Change Expired() signature to Expired(now time.Time)
    @dauTT
    dauTT committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ab5264f View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. 1) Add override flag to UpdateClient function 

    2) Fix tests
    @dauTT
    dauTT committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b85e6c9 View commit details
    Browse the repository at this point in the history

  2. Refactor HandleClientUpdateProposal

    @dauTT
    dauTT committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b454bf8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. 1) Extend exported Header interface with MarshalBinaryBare and Unmars… 

    …halBinaryBare methods

2) Move ClientUpdateProposal message to from ibc.proto to client.proto
3) Refactoring code
4) Add override flag to UpdateClient method
5) Fix tests
    @dauTT
    dauTT committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    73cbb37 View commit details
    Browse the repository at this point in the history

  2. 1) Uncomment tests and clean up code 

    2) Add basic validation of the header (ValidateBasic) when the override flag is true
    @dauTT
    dauTT committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b7dae11 View commit details
    Browse the repository at this point in the history

  3. Cosmetic changes

    @dauTT
    dauTT committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    619e55a View commit details
    Browse the repository at this point in the history

  4. Add TODO comments

    @dauTT
    dauTT committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c9cf600 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. Merge branch 'master' into dauTT/ADR-26-issue-6998

    @dauTT
    dauTT committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    49c0aa3 View commit details
    Browse the repository at this point in the history

  2. Fix header MarshalBinaryBare, UnmarshalBinaryBare by using protobuf e… 

    …ncoding/decoding
    @dauTT
    dauTT committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    ad5c261 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dauTT/ADR-26-issue-6998

    @dauTT
    dauTT committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    bad2bfc View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Merge branch 'master' into ADR-26-issue-6998

    @cwgoes
    cwgoes committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    bbc0af4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ADR-26-issue-6998

    @fedekunze
    fedekunze committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    935ffd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Merge branch 'master' into ADR-26-issue-6998

    @dauTT
    dauTT committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ad196fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ADR-26-issue-6998

    @fedekunze
    fedekunze committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    b7cab36 View commit details
    Browse the repository at this point in the history

  3. Fix proto comments

    @dauTT
    dauTT committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    f9090dc View commit details
    Browse the repository at this point in the history

  4. Fix override logic

    @dauTT
    dauTT committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    928ca3e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ADR-26-issue-6998

    @dauTT
    dauTT committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    5eb466b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. undo gettimestamp for solo machine and localhost

    @colin-axner
    colin-axner committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    01f6857 View commit details
    Browse the repository at this point in the history

  2. add update after proposal func, some major refactoring in progress, v… 

    …arious issues addressed
    @colin-axner
    colin-axner committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    05a5e26 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. fix tendermint proposal update handling

    @colin-axner
    colin-axner committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    8656f98 View commit details
    Browse the repository at this point in the history

  2. fix merge conflicts

    @colin-axner
    colin-axner committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9514076 View commit details
    Browse the repository at this point in the history

  3. run make proto-gen

    @colin-axner
    colin-axner committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    592c5b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. merge master

    @colin-axner
    colin-axner committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    8151bb9 View commit details
    Browse the repository at this point in the history

  2. remove timestamp from tendemint client

    @colin-axner
    colin-axner committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    40ca6b9 View commit details
    Browse the repository at this point in the history

  3. fix merge conflicts

    @colin-axner
    colin-axner committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    6c6af7f View commit details
    Browse the repository at this point in the history

  4. fix build issue for tm types

    @colin-axner
    colin-axner committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    408033e View commit details
    Browse the repository at this point in the history

  5. apply various review comments

    @colin-axner
    colin-axner committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    27d75b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. add tests for 02-client functionality

    @colin-axner
    colin-axner committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    2787e3a View commit details
    Browse the repository at this point in the history

  2. self review fixes

    @colin-axner
    colin-axner committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    c1d997e View commit details
    Browse the repository at this point in the history

  3. merge master

    @colin-axner
    colin-axner committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    b19a842 View commit details
    Browse the repository at this point in the history

  4. typo

    @colin-axner
    colin-axner committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    8067630 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. update tests slightly

    @colin-axner
    colin-axner committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    11ebacf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:cosmos/cosmos-sdk into ADR-26-iss… 

    …ue-6998
    @colin-axner
    colin-axner committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7266199 View commit details
    Browse the repository at this point in the history

  3. update tendermint proposal handling tests

    @colin-axner
    colin-axner committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    500eeee View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Update x/ibc/02-client/keeper/proposal.go 

    Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
    @colin-axner @fedekunze
    colin-axner and fedekunze committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    28b14e9 View commit details
    Browse the repository at this point in the history

  2. Update x/ibc/07-tendermint/types/proposal_handle.go 

    Co-authored-by: Aditya <adityasripal@gmail.com>
    @colin-axner @AdityaSripal
    colin-axner and AdityaSripal committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    6420c71 View commit details
    Browse the repository at this point in the history

  3. Update x/ibc/07-tendermint/types/proposal_handle.go 

    Co-authored-by: Aditya <adityasripal@gmail.com>
    @colin-axner @AdityaSripal
    colin-axner and AdityaSripal committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    82b75c4 View commit details
    Browse the repository at this point in the history

  4. apply most of @fedekunze and some of @AdityaSripal suggestions

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2228c11 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ADR-26-issue-6998' of github.com:dauTT/cosmos-sdk into … 

    …ADR-26-issue-6998
    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    4d0c535 View commit details
    Browse the repository at this point in the history

  6. convert test to bools

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    020c6ff View commit details
    Browse the repository at this point in the history

  7. update docs and increase code cov

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7042150 View commit details
    Browse the repository at this point in the history

  8. merge master

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    ca6393b View commit details
    Browse the repository at this point in the history

  9. fix build

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    234ad00 View commit details
    Browse the repository at this point in the history

  10. fix typo, remove omitempty

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    ffdf601 View commit details
    Browse the repository at this point in the history

  11. add switch

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    567aa2a View commit details
    Browse the repository at this point in the history

  12. apply @fedekunze latest suggestions

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    90d92bf View commit details
    Browse the repository at this point in the history

  13. fix lint

    @colin-axner
    colin-axner committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d4053ab View commit details
    Browse the repository at this point in the history

  14. Update x/ibc/02-client/keeper/proposal_test.go

    @AdityaSripal
    AdityaSripal committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    01663a9 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into ADR-26-issue-6998

    @mergify
    mergify[bot] committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5bcd982 View commit details
    Browse the repository at this point in the history