Implement ADR 026 #7029

dauTT · 2020-08-12T23:46:30Z

Description

Implemented all the points of ADR 026:

Require Tendermint light clients (ICS 07) to be created with the following additional flags
i. allow_governance_override_after_expiry (boolean, default false)

Require Tendermint light clients (ICS 07) to expose the following additional internal query functions
i. Expired() boolean, which returns whether or not the client has passed the trusting period since the last update (in which case no headers can be validated)

Require Tendermint light clients (ICS 07) to expose the following additional state mutation functions
i. Unfreeze(), which unfreezes a light client after misbehaviour and clears any frozen height previously set

Require Tendermint light clients (ICS 07) & solo machine clients (ICS 06) to be created with the following additional flags
i. allow_governance_override_after_misbehaviour (boolean, default false)

Add a new governance proposal type, ClientUpdateProposal, in the x/ibc module
i. Extend the base Proposal with a client identifier (string) and a header (bytes, encoded in a client-type-specific format)
ii. If this governance proposal passes, the client is updated with the provided header, if and only if:
a. allow_governance_override_after_expiry is true and the client has expired (Expired() returns true)
b. allow_governance_override_after_misbehaviour is true and the client has been frozen (Frozen() returns true)
a. In this case, additionally, the client is unfrozen by calling Unfreeze()

TODO:

Add NewSubmitClientUpdateProposalCmd

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

…teClientCmd

…e latest_timestamp to the message ClientState in proto/ibc/tendermint/tendermint.proto 2) Autogenerate x/ibc/07-tendermint/types/tendermint.pb.go by running 'make proto-gen'. Strangely, as a side effect x/distribution/types/genesis.pb.go, x/evidence/types/genesis.pb.go were also modified by the command 'make proto-gen' 3) Add Expired() function

codecov · 2020-08-12T23:50:36Z

Codecov Report

Merging #7029 into master will increase coverage by 0.21%.
The diff coverage is 98.69%.

@@            Coverage Diff             @@
##           master    #7029      +/-   ##
==========================================
+ Coverage   54.66%   54.88%   +0.21%     
==========================================
  Files         571      575       +4     
  Lines       39302    39435     +133     
==========================================
+ Hits        21486    21644     +158     
+ Misses      16039    16012      -27     
- Partials     1777     1779       +2

…tStatus 2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus

lgtm-com · 2020-08-13T20:17:13Z

This pull request introduces 1 alert when merging 0ec9447 into 4c762db - view on LGTM.com

new alerts:

1 for Useless assignment to field

dauTT · 2020-08-16T23:12:05Z

Note: Due to issue #6476, I could not run the command make proto-gen with the latest code in the master. So I used an outdated version of scripts/protocgen.sh (commit: 69bbb8b327c3cfb967d969bcadeb9b0aef144df6) to autogenerate the pb.go files while merging the master branch with my own. Hopefully I didn't introduce any major bug by using this approach.

cwgoes

Thanks, mostly solid, a few questions on the proposal handler.

x/ibc/02-client/handler.go

fedekunze

Thanks @dauTT! Left a few comments but implementation-wise looks great 🙂

proto/ibc/types/ibc.proto

x/ibc/02-client/types/errors.go

x/ibc/07-tendermint/types/client_state.go

x/ibc/types/keys.go

x/ibc/types/proposal.go

x/ibc/02-client/handler.go

x/ibc/07-tendermint/tendermint_test.go

x/ibc/07-tendermint/types/client_state.go

simapp/app.go

x/ibc/09-localhost/types/client_state.go

AdityaSripal

Great work @dauTT !! There are still some implementation issues that I've marked.

I don't understand how you're expiration recovery mechanism would work without some way to update the clientTime before lite.Verify is being called. WIll look into why your test case on this is passing

x/ibc/07-tendermint/types/client_state.go

x/ibc/07-tendermint/types/msgs.go

x/ibc/proposal_handler_test.go

x/ibc/02-client/handler.go

x/ibc/07-tendermint/tendermint_test.go

x/ibc/proposal_handler_test.go

AdityaSripal · 2020-08-17T19:26:33Z

x/ibc/02-client/handler.go

+			updateClientFlag = true
+		}
+
+		if tmClientState.AllowGovernanceOverrideAfterMisbehaviour && tmClientState.IsFrozen() {


This is incorrect behaviour from my understanding.

Suppose AllowGovernanceOverrideAfterExpiry = false and AllowGovernanceOverrideAfterMisbehaviour = true

And the client is frozen AND expired, then the correct behaviour is to reject the proposal since client is still expired even if it gets unfrozen.

Similarly, when AllowGovernanceOverrideAfterExpire = true and AllowGovernanceOverrideAfterMisbehaviour = false

And the client is frozen AND expired, then the update proposal should fail since the client is still frozen.

cc: @cwgoes

This code will allow the proposal to pass in the above cases

When we change this above, we should end up with two separate paths (UpdateClient will be called here, but not in the above path)

AdityaSripal

So figured out why your expired test cases were passing. Update logic uses ctx.BlockTime() for the current timestamp, which in your tests is always within trusting period of the last stored consensus state.

Once you fix the tests you should see them fail. As @cwgoes mentioned, you'll need some sort of flag in update logic to handle the case where we are overriding.

If override = true, then you need to override the trusted time so that it passes the lite.Verify checks.

Specifically you'll need to change this line:
https://github.com/cosmos/cosmos-sdk/blob/master/x/ibc/07-tendermint/types/update.go#L118

to something like:

Time: newHeader.Time

only when override = true. If override = false, keep as is.

EDIT: This solution will not work because all the time checks are taken care of in lite.Verify if the updating header time is also expired. Can we assume that header.TIme is always going to be within Trusting period of ctx.BlockTime? I assume not

x/ibc/proposal_handler_test.go

AdityaSripal · 2020-08-17T19:59:19Z

x/ibc/proposal_handler_test.go

+			clientkeeper := ibcKeeper.ClientKeeper
+
+			// create test client
+			_, err := clientkeeper.CreateClient(suite.ctx, clientID, tc.clientState, suite.consensusState)


Here it is possible for tc.clientState.Timestamp != suite.consensusState.Time

This is confusing, change both to be in sync for each test case as I have shown above

There is a check that I want to add to prevent the above situation:

However, If I do add the check many existing tests will fail. So I am considering to open a new PR for this. But let see, perhaps is not that difficult to fix all the tests.

…ue-6998

colin-axner · 2020-09-03T14:38:19Z

this is ready for review again. Still needs some more tests, but 95% done

fedekunze

Looks good! Left a few comments but the logic itself is clean and simpler to understand

x/ibc/testing/chain.go

x/ibc/09-localhost/types/client_state.go

x/ibc/light-clients/solomachine/types/proposal_handle.go

x/ibc/07-tendermint/client/cli/tx.go

x/ibc/02-client/types/proposal.go

fedekunze · 2020-09-03T17:30:33Z

x/ibc/07-tendermint/types/proposal_handle.go

+		)
+	}
+
+	if cs.IsFrozen() {


nit, can we use switch for all the conditions here and move the contents to private functions? It's kinda hard to follow the logic, especially the last section were we should be checking for expired client

can you do a switch on a struct? Otherwise I'm not sure how to do this

I tried doing a switch on the client state but got:
cannot switch on cs (type ClientState) (struct containing []*ics23.ProofSpec cannot be compared)

switch { case cs.IsFrozen(): // logic case !cs.AllowUpdateAfterExpiry, !cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()): return nil, nil, sdkerrors.Wrap(clienttypes.ErrUpdateClientFailed, "client cannot be updated with proposal") case cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()): // logic default: // error invalid case? }

ah I see, this will be much better. I modified the suggestion above a little in the latest commit, let me know if you think it needs any changes

fedekunze · 2020-09-03T17:31:46Z

x/ibc/07-tendermint/types/proposal_handle.go

+		return nil, nil, sdkerrors.Wrap(clienttypes.ErrUpdateClientFailed, "client cannot be updated with proposal")
+	}
+
+	// the client is expired and either AllowUpdateAfterMisbehaviour or AllowUpdateAfterExpiry


I feel the expiry should be checked with another condition? Using switch here would help readability

This check is implicit based on the possible conditions. I can add an if condition, it would just be redundant. Do you have any proposed alternative layout?

x/ibc/07-tendermint/types/proposal_handle.go

AdityaSripal

Mostly nits, just have one substantial request on tendermint proposal_handle_test.go

Will ACK once that request is addressed and the rest of tests are complete. Great work everyone!!

x/ibc/07-tendermint/types/proposal_handle.go

AdityaSripal · 2020-09-03T21:31:45Z

x/ibc/07-tendermint/types/proposal_handle.go

+		if !cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()) {
+			return cs.CheckHeaderAndUpdateState(ctx, cdc, clientStore, header)


If this case is hit, refreezing is still possible. Doesn't need to block the PR, but something to be noted

yup was planning to update docs for this

x/ibc/07-tendermint/types/proposal_handle.go

AdityaSripal · 2020-09-03T21:38:16Z

x/ibc/light-clients/solomachine/types/proposal_handle.go

+
+	consensusState := &ConsensusState{
+		Sequence:  smHeader.Sequence,
+		PublicKey: smHeader.NewPublicKey,


Should we check that NewPublicKey != CurrentPublicKey?

seems reasonable to me

should this be checked on regular updates as well? cc @cwgoes

on a related note, should the sequence set in consensus state == header.GetSequence() or should it be header.GetSequence + 1 like in update.go?

I think we can check that newPublicKey != currentPublicKey, there's no reason to pass a proposal if you have access to the current public key.

This is a bit of a special case, since we're resetting the sequence, I think having it be equal is fine.

x/ibc/07-tendermint/types/proposal_handle_test.go

AdityaSripal · 2020-09-03T21:48:49Z

x/ibc/07-tendermint/types/proposal_handle_test.go

+
+// to expire clients, time needs to be fast forwarded on both chainA and chainB.
+// this is to prevent headers from failing when attempting to update later.
+func (suite *TendermintTestSuite) TestCheckProposedHeaderAndUpdateState() {


The structure of this test is confusing and difficult to understand imo. I suggest a clearer approach

AdityaSripal · 2020-09-03T21:49:36Z

x/ibc/07-tendermint/types/proposal_handle_test.go

+		malleate        func()
+		expPassUnfreeze bool // expected result using a header for unfreezing
+		expPassUnexpire bool // expected result using a header for unexpiring


Suggested change

malleate func()

expPassUnfreeze bool // expected result using a header for unfreezing

expPassUnexpire bool // expected result using a header for unexpiring

AllowUpdateAfterExpiry bool

AllowUpdateAfterMisbehaviour bool

expPassUnfreeze bool // expected result using a header for unfreezing

expPassUnexpire bool // expected result using a header for unexpiring

This means you only need 4 test-case structs to test each possible configuration

AdityaSripal · 2020-09-03T21:53:55Z

x/ibc/07-tendermint/types/proposal_handle_test.go

+		// for each test case a header used for unexpiring clients and unfreezing
+		// a client are each tested to ensure the work as expected and that
+		// unexpiring headers cannot unfreeze clients.
+		suite.Run(tc.name, func() {


Here with each test case construct the clientState with the provided override flags.

Test UpdateProposal against a valid clientstate (this is optional, you can remove this step)

Freeze the client and provide the update header and see if you get the expected result

Unfreeze and expire the client and provide the update header and see if you get the expected result

Freeze and expire the client and provide the update header and see if you get the expected result

This would be much clearer imo, and require less test-case structs

I don't understand this reduction. Each of the test cases in one of the four categories have varying results for the combo of expPassUnfreeze and expPassUnexpire? Trying to program this logic into the suite.Run becomes messy and harder to reason about imo. I don't think I can cleanly reduce the test cases to 4 without dropping some testing logic (not testing unexpiry headers on frozen clients etc). I think it is important to test weaker headers on test cases expected to have stronger headers to ensure they don't pass.

I can abstract the clientState to be constructed on the override flags. I think any other improvement can be done in a followup (or you can push directly) because I don't follow.

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: Aditya <adityasripal@gmail.com>

cwgoes

ACK modulo outstanding comments

This logic is definitely much cleaner, thanks @colin-axner 🎉.

cwgoes · 2020-09-04T12:14:06Z

x/ibc/light-clients/solomachine/types/proposal_handle.go

+
+	consensusState := &ConsensusState{
+		Sequence:  smHeader.Sequence,
+		PublicKey: smHeader.NewPublicKey,


I think we can check that newPublicKey != currentPublicKey, there's no reason to pass a proposal if you have access to the current public key.

This is a bit of a special case, since we're resetting the sequence, I think having it be equal is fine.

…ADR-26-issue-6998

addressed

fedekunze

ACK. Final minor comments and pending switch condition from the previous review

fedekunze · 2020-09-04T15:40:18Z

x/ibc/02-client/keeper/proposal.go

+		return sdkerrors.Wrapf(types.ErrClientTypeNotFound, "cannot update client with ID %s", p.ClientId)
+	}
+
+	if clientType == exported.Localhost {


Suggested change

if clientType == exported.Localhost {

if clientType == exported.Localhost || p.ClientId == exported.ClientTypeLocalHost {

fedekunze · 2020-09-04T15:41:21Z

x/ibc/02-client/types/proposal.go

+		return nil, err
+	}
+
+	return &ClientUpdateProposal{title, description, clientID, any}, nil


nit break down and use named fields

fedekunze · 2020-09-04T15:41:53Z

x/ibc/02-client/types/proposal.go

+	if err := header.ValidateBasic(); err != nil {
+		return err
+	}
+
+	return nil


Suggested change

if err := header.ValidateBasic(); err != nil {

return err

}

return nil

return header.ValidateBasic()

fedekunze · 2020-09-04T15:42:16Z

x/ibc/02-client/types/proposal_test.go

+		} else {
+			require.Error(t, err, tc.name)
+		}
+


Suggested change

fedekunze · 2020-09-04T15:43:57Z

x/ibc/light-clients/solomachine/types/proposal_handle_test.go

+	var (
+		header exported.Header
+	)


Suggested change

var (

header exported.Header

)

var header exported.Header

fedekunze · 2020-09-04T15:44:44Z

x/ibc/spec/01_concepts.md

@@ -144,3 +144,25 @@ in the handshake callbacks.

 Implementations which do not feel they would benefit from versioning can do
 basic string matching using a single compatible version.
+
+## ClientUpdateProposal


nit, can you add ADR26 to the ibc/spec readme references?

fedekunze · 2020-09-04T15:45:46Z

x/ibc/spec/01_concepts.md

+The localhost client cannot be updated by a governance proposal. 
+
+The solo machine client requires the boolean flag 'AllowUpdateAfterProposal' to be set
+to true in order to be updated by a proposal. This is set upon client creation and cannot 
+be updated later.
+
+The tendermint client has two flags update flags, 'AllowUpdateAfterExpiry' and 


nit, create h3 subsections (eg ### Localhost Client Proposal)

I was thinking this should just be moved to each clients own spec when we add them

fedekunze · 2020-09-04T16:01:32Z

x/ibc/07-tendermint/types/proposal_handle.go

 		if !cs.AllowUpdateAfterMisbehaviour {
 			return nil, nil, sdkerrors.Wrap(clienttypes.ErrUpdateClientFailed, "client is not allowed to be unfrozen")
 		}

 		// unfreeze the client
 		cs.FrozenHeight = clienttypes.Height{}

-		// if the client is frozen but not expired, do full validation of the header
-		// NOTE: the client may be frozen again since the misbehaviour evidence may
-		// not be expired yet
-		if !cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()) {
+		// if the client is expired we unexpire the client using softer validation, otherwise
+		// full validation on the header is performed.
+		if cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()) {
+			return cs.unexpireClient(consensusState, tmHeader, ctx.BlockTime())
+		} else {
+			// NOTE: the client may be frozen again since the misbehaviour evidence may
+			// not be expired yet
 			return cs.CheckHeaderAndUpdateState(ctx, cdc, clientStore, header)
 		}


return cs.unfreezeClient(...)?

I think it's fine for now. unexpire is needed because it is called twice

x/ibc/02-client/keeper/proposal_test.go

@fedekunze

* Add allow_governance_override_after_expiry flag to tendermint NewCreateClientCmd * 1) Add LatestTimestamp to ClientState struct by adding a new attribute latest_timestamp to the message ClientState in proto/ibc/tendermint/tendermint.proto 2) Autogenerate x/ibc/07-tendermint/types/tendermint.pb.go by running 'make proto-gen'. Strangely, as a side effect x/distribution/types/genesis.pb.go, x/evidence/types/genesis.pb.go were also modified by the command 'make proto-gen' 3) Add Expired() function * Fix tests * 1) Add allow_governance_override_after_expiry flag to tendemint clientStatus 2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus * Cosmetic changes * Fix tests * Add Unfreeze function * Add new ClientUpdateProposal type * Add minor fixes * Add NewClientUpdateProposalHandler unit tests * Fix proto-lint-docker * Delete x/ibc/07-tendermint/tendermint_test.go * Follow convention to put signer last in msg function signature * 1) Add GetLatestTimestamp function to ClientStatus interface 2) Change Expired() signature to Expired(now time.Time) * 1) Add override flag to UpdateClient function 2) Fix tests * Refactor HandleClientUpdateProposal * 1) Extend exported Header interface with MarshalBinaryBare and UnmarshalBinaryBare methods 2) Move ClientUpdateProposal message to from ibc.proto to client.proto 3) Refactoring code 4) Add override flag to UpdateClient method 5) Fix tests * 1) Uncomment tests and clean up code 2) Add basic validation of the header (ValidateBasic) when the override flag is true * Cosmetic changes * Add TODO comments * Fix header MarshalBinaryBare, UnmarshalBinaryBare by using protobuf encoding/decoding * Fix proto comments * Fix override logic * undo gettimestamp for solo machine and localhost * add update after proposal func, some major refactoring in progress, various issues addressed * fix tendermint proposal update handling * run make proto-gen * remove timestamp from tendemint client * fix build issue for tm types * apply various review comments * add tests for 02-client functionality * self review fixes * typo * update tests slightly * update tendermint proposal handling tests * Update x/ibc/02-client/keeper/proposal.go Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update x/ibc/07-tendermint/types/proposal_handle.go Co-authored-by: Aditya <adityasripal@gmail.com> * Update x/ibc/07-tendermint/types/proposal_handle.go Co-authored-by: Aditya <adityasripal@gmail.com> * apply most of @fedekunze and some of @AdityaSripal suggestions * convert test to bools * update docs and increase code cov * fix build * fix typo, remove omitempty * add switch * apply @fedekunze latest suggestions * fix lint * Update x/ibc/02-client/keeper/proposal_test.go Co-authored-by: Christopher Goes <cwgoes@pluranimity.org> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Colin Axner <colinaxner@berkeley.edu> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

dauTT added 2 commits August 13, 2020 01:23

Add allow_governance_override_after_expiry flag to tendermint NewCrea…

0b2ca3a

…teClientCmd

dauTT changed the title ~~Adr 26 issue 6998~~ Implement ADR 026 Aug 12, 2020

dauTT added 5 commits August 13, 2020 20:33

Fix tests

4e131a5

1) Add allow_governance_override_after_expiry flag to tendemint clien…

54e2c10

…tStatus 2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus

Cosmetic changes

46753bc

Fix tests

bbaf594

Add Unfreeze function

0ec9447

dauTT added 5 commits August 15, 2020 15:00

Add new ClientUpdateProposal type

11e5545

Add minor fixes

7725884

Add NewClientUpdateProposalHandler unit tests

024c7a6

Merge branch 'master' into dauTT/ADR-26-issue-6998

4c7331e

Fix proto-lint-docker

2481b5e

dauTT marked this pull request as ready for review August 16, 2020 22:51

dauTT requested review from aaronc, alessio, alexanderbez, clevinson, fedekunze and jgimeno as code owners August 16, 2020 22:51

fedekunze requested a review from cwgoes August 17, 2020 12:17

cwgoes suggested changes Aug 17, 2020

View reviewed changes

x/ibc/02-client/handler.go Outdated Show resolved Hide resolved

x/ibc/02-client/handler.go Outdated Show resolved Hide resolved

fedekunze suggested changes Aug 17, 2020

View reviewed changes

AdityaSripal requested changes Aug 17, 2020

View reviewed changes

dauTT added 2 commits August 18, 2020 01:57

Delete x/ibc/07-tendermint/tendermint_test.go

ec39812

Follow convention to put signer last in msg function signature

449f7b6

colin-axner added 3 commits September 3, 2020 11:06

update tests slightly

11ebacf

Merge branch 'master' of github.com:cosmos/cosmos-sdk into ADR-26-iss…

7266199

…ue-6998

update tendermint proposal handling tests

500eeee

fedekunze reviewed Sep 3, 2020

View reviewed changes

AdityaSripal requested changes Sep 3, 2020

View reviewed changes

colin-axner and others added 3 commits September 4, 2020 11:26

Update x/ibc/02-client/keeper/proposal.go

28b14e9

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Update x/ibc/07-tendermint/types/proposal_handle.go

6420c71

Co-authored-by: Aditya <adityasripal@gmail.com>

Update x/ibc/07-tendermint/types/proposal_handle.go

82b75c4

Co-authored-by: Aditya <adityasripal@gmail.com>

cwgoes approved these changes Sep 4, 2020

View reviewed changes

colin-axner added 6 commits September 4, 2020 15:16

apply most of @fedekunze and some of @AdityaSripal suggestions

2228c11

Merge branch 'ADR-26-issue-6998' of github.com:dauTT/cosmos-sdk into …

4d0c535

…ADR-26-issue-6998

convert test to bools

020c6ff

update docs and increase code cov

7042150

merge master

ca6393b

fix build

234ad00

colin-axner marked this pull request as ready for review September 4, 2020 15:31

fix typo, remove omitempty

ffdf601

fedekunze approved these changes Sep 4, 2020

View reviewed changes

colin-axner added 2 commits September 4, 2020 17:53

add switch

567aa2a

apply @fedekunze latest suggestions

90d92bf

fedekunze reviewed Sep 4, 2020

View reviewed changes

fix lint

d4053ab

AdityaSripal approved these changes Sep 4, 2020

View reviewed changes

x/ibc/02-client/keeper/proposal_test.go Outdated Show resolved Hide resolved

Update x/ibc/02-client/keeper/proposal_test.go

01663a9

AdityaSripal added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 4, 2020

Merge branch 'master' into ADR-26-issue-6998

5bcd982

mergify bot merged commit b52ffa0 into cosmos:master Sep 4, 2020

		if !cs.IsExpired(consensusState.Timestamp, ctx.BlockTime()) {
		return cs.CheckHeaderAndUpdateState(ctx, cdc, clientStore, header)

	if clientType == exported.Localhost {
	if clientType == exported.Localhost \|\| p.ClientId == exported.ClientTypeLocalHost {

Implement ADR 026 #7029

Implement ADR 026 #7029

Conversation

dauTT commented Aug 12, 2020 • edited by fedekunze Loading

Description

codecov bot commented Aug 12, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Aug 13, 2020

dauTT commented Aug 16, 2020

cwgoes left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

AdityaSripal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdityaSripal left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colin-axner commented Sep 3, 2020

fedekunze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedekunze Sep 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdityaSripal left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwgoes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dauTT commented Aug 12, 2020 •

edited by fedekunze

Loading

codecov bot commented Aug 12, 2020 •

edited

Loading

AdityaSripal left a comment •

edited

Loading

fedekunze Sep 4, 2020 •

edited

Loading

AdityaSripal left a comment •

edited

Loading