Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use gRPC v1.33.2 #7925

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Update dependencies to use gRPC v1.33.2 #7925

merged 4 commits into from
Nov 15, 2020

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Nov 13, 2020

Description

Updated gRCP version to v1.33.2 since v1.33.0 was deleted (see grpc/grpc-go#3945).
As a consequence, cosmos/iavl also needed to be updated to v0.15.0-rc5 to work properly.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@RiccardoM RiccardoM changed the title Update gRPC to v1.33.1 Update gRPC dependencies Nov 13, 2020
@RiccardoM RiccardoM changed the title Update gRPC dependencies Update dependencies to use gRPC v1.33.2 Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #7925 (9f0b533) into master (7e6978a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7925   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files         612      612           
  Lines       39000    39000           
=======================================
  Hits        21129    21129           
  Misses      15698    15698           
  Partials     2173     2173           

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 15, 2020
@mergify mergify bot merged commit 6cbbe0d into cosmos:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants