Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

upgrade changes cleanup #236

Merged
merged 10 commits into from
Apr 1, 2020
Merged

upgrade changes cleanup #236

merged 10 commits into from
Apr 1, 2020

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Apr 1, 2020

Description

Trying to isolate the changes from the cleanup from #183

TODO:

  • fix tx receipts

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

app/ethermint.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor Author

ok, everything is working fine but the tx receipts

@fedekunze fedekunze marked this pull request as ready for review April 1, 2020 14:07
@fedekunze
Copy link
Contributor Author

Tested and reps should look like this:

ethermint-deploy

yarn start 
yarn run v1.15.2
$ node ./web3/deploy_contract.js
Compiling contract code...
Unlocked account address: 	 0x396F3C4Af94b18c0d87E5cE6d39089FAC0f19950
Deploying contract...
Deployed contract Address: 	 0x33A5a6e4bE6874030C3A744580D4a4D877917Bb1
Counter pre increment is: 	 0
Sending add transaction...
Add tx finalized in block: 	 5
Counter post increment is: 	 1
✨  Done in 8.72s.

REST server

[{"msg_index":0,"success":true,"log":"","events":[{"type":"message","attributes":[{"key":"action","value":"ethereum"}]}]}]

Daemon

I[2020-04-01|11:02:18.804] Added good transaction                       module=mempool tx=6E2B13E500627B1EF7C59ACF521A408A3B5ECAF18D190B169FF6333AFE1D9B7E res="&{CheckTx:log:\"[{\\\"msg_index\\\":0,\\\"success\\\":true,\\\"log\\\":\\\"\\\",\\\"events\\\":[{\\\"type\\\":\\\"message\\\",\\\"attributes\\\":[{\\\"key\\\":\\\"action\\\",\\\"value\\\":\\\"ethereum\\\"}]}]}]\" gas_wanted:50000 gas_used:21272 events:<type:\"message\" attributes:<key:\"action\" value:\"ethereum\" > > }" height=4 total=1

Copy link

@letterj letterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was able to deploy a chain, run the rest server and successfully deploy a contract.

@fedekunze fedekunze merged commit da9157e into development Apr 1, 2020
@fedekunze fedekunze deleted the cleanup branch April 1, 2020 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants