Additional review of prop 29 and migration testing #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmanian
requested review from
alessio,
alexanderbez,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 11.58% 12.57% +0.98%
==========================================
Files 8 8
Lines 673 684 +11
==========================================
+ Hits 78 86 +8
+ Misses 586 580 -6
- Partials 9 18 +9 |
fedekunze
approved these changes
Jan 22, 2021
| } | ||
|
|
||
| // add the balances to the bank genesis | ||
| bankGenesis.Balances = append(bankGenesis.Balances, fundRecovery.GetRemainingBalances()...) |
There was a problem hiding this comment.
My only concern here is that a balance uniqueness is not validated on the bank genesis validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current prop29 implementation causes errors when migrating the state due two issues.
The JSON parsing of the recovery messages is failing on
maindue to handling of escape priorities.There were also correctness issues in the verification of Ethereum signatures both in terms of correctness. This is also resolved.
This can be tested by downloading the Nov 1 hub snapshot and running.
cosmos/gaia/build/gaiad migrate ~/3924406.cosmoshub-3.jsonhttps://storage.googleapis.com/stargate-genesis/3924406.cosmoshub-3.json
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)