Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20 V2 Support for Multi Denom #5793

Closed
13 of 24 tasks
chatton opened this issue Feb 1, 2024 · 2 comments · Fixed by #6352
Closed
13 of 24 tasks

ICS20 V2 Support for Multi Denom #5793

chatton opened this issue Feb 1, 2024 · 2 comments · Fixed by #6352

Comments

@chatton
Copy link
Contributor

chatton commented Feb 1, 2024

Requirements document

Shout out to @charleenfei for all the work done so far in this PoC branch that we've been working on.

In the linked PoC, we have the spec changes implemented and unit and e2e tests passing (additional ones still need to be added)

In the PoC, we have some full unit tests and E2E tests passing and can be used as a reference, unit and e2e.

This issue will outline the proposed order of PR creation for the changes to be most easily reviewed.

IBC spec

1020

ADRs

Milestones

Implementation issues

QA scenarios

Automated e2e tests

Pre-releases

Checklist

  • Internal audit(s)
  • External audit(s)
  • Documentation
  • Swagger
  • Integration with ledger
  • Integration with relayers:
    • Hermes
    • Rly

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@srdtrk
Copy link
Member

srdtrk commented Feb 2, 2024

When we are doing such a rewrite, is it also possible to migrate storage to "cosmossdk.io/collections"?

@damiannolan
Copy link
Member

We should also test ledger support since MsgTransfer is being modified. I will add to the checklist on the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

5 participants