Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recv_packet handler incorrectly queries packet_receipt and next_sequence_recv using packet's source_{port, channel} #40

Closed
5 tasks
hu55a1n1 opened this issue Jun 14, 2022 · 0 comments · Fixed by informalsystems/hermes#2294
Assignees
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

Summary of Bug

modules/src/core/ics04_channel/handler/recv_packet::process incorrectly queries packet_receipt and next_sequence_recv using packet's source_{port, channel}. It also creates the result incorrectly and should instead use the packet.destination_{port, channel}, as that is guaranteed to be unique ->

https://github.com/informalsystems/ibc-rs/blob/master/modules/src/core/ics04_channel/handler/recv_packet.rs#L83-L134

See corresponding behaviour in ibc-go ->
https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/packet.go#L232-L283

Version

v0.15.0

Acceptance Criteria

recv_packet handler is fixed to use the appropriate port/channel ids.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jun 14, 2022
@hu55a1n1 hu55a1n1 self-assigned this Jun 14, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
1 participant