Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS 15: Cosmos Signed Messages #15

Closed
cwgoes opened this issue Feb 12, 2019 · 8 comments
Closed

ICS 15: Cosmos Signed Messages #15

cwgoes opened this issue Feb 12, 2019 · 8 comments
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Feb 12, 2019

Ported from the spec in the SDK repository.

Suggested changes/alterations to that spec:

  • Organize in ICS format
  • More clearly describe requirements of hashing algorithm & signing algorithm (and maybe parameterize the specification over them)
  • Investigate distinction between custom messages (more easily defined in the SDK than e.g. Ethereum) and signed messages, and what use we expect for each (block explorers? DEXs? validator authentication mechanisms?)
  • Include specification for signing structured data using JSON schema
  • Include options for domain specification / replay prevention (nonce, block height, timestamp)
@alexanderbez
Copy link
Contributor

Thanks @cwgoes, I'll take care of this shortly.

@jackzampolin
Copy link
Member

Hell yeah @alexanderbez!

@cwgoes cwgoes changed the title ICS ?: Cosmos Signed Messages ICS 15: Cosmos Signed Messages Mar 5, 2019
@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 7, 2019

@cwgoes can you please elaborate more on the following or possibly reword:

Investigate distinction between custom messages (more easily defined in the SDK than e.g. Ethereum) and signed messages, and what use we expect for each (block explorers? DEXs? validator authentication mechanisms?)

@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 7, 2019

Also, do we want to support messages that are both ASCII text and structured human-readable data? Can we leave this up to implementation?

@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 11, 2019

Also, do we want to support messages that are both ASCII text and structured human-readable data? Can we leave this up to implementation?

Can we have a structured data standard which encapsulated ASCII-text (as a datatype option)?

@cwgoes can you please elaborate more on the following or possibly reword:

Investigate distinction between custom messages (more easily defined in the SDK than e.g. Ethereum) and signed messages, and what use we expect for each (block explorers? DEXs? validator authentication mechanisms?)

Let's think about - and write down - which use cases signed messages should be used for (maybe validator / delegator authentication, communication within wallets) and which use cases we expect Cosmos blockchains to specify custom transactions for (most actual state transitions). We can change this later, but it's useful to brainstorm.

@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 12, 2019

Also this is interesting.

@cwgoes cwgoes removed their assignment May 11, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 17, 2019

I now think it may be prudent to instead put this specification in the Cosmos SDK repository.

Ref #185

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 24, 2019

Per the above I'm going to close this. Feel free to reopen if you have objections.

@cwgoes cwgoes closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants