You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also, I must admit that seeing go code lightly masquerading as the typescript spec code (just changed the name from func to function otherwise Go syntax) is a bit surprising.
The text was updated successfully, but these errors were encountered:
ethanfrey
changed the title
Define De/Serialization format for EXECUTE_TX
ics27: Define De/Serialization format
Jan 4, 2022
mpoke
changed the title
ics27: Define De/Serialization format
ICS27: Define De/Serialization format
Mar 17, 2022
We could switch to json which would look like (the "type" encoding changes):
{"type":1,"data":"ZGF0YQ==","memo":"memo"}
If we made the switch, we would continue using proto3 json to unmarshal because the standard json library would fail to unmarshal the proto3 json encoding (which may be sent by a chain on an existing version)
I read that there is one type EXECUTE_TX, which is fine.
And when received, we should parse the bytes into multiple messages: https://github.com/cosmos/ibc/tree/master/spec/app/ics-027-interchain-accounts#packet-relay
However, the serialization format is never defined in the spec. This make building a compatible implementation impossible. Please define this format explicitly here: https://github.com/cosmos/ibc/tree/master/spec/app/ics-027-interchain-accounts#packet-data
Also, I must admit that seeing go code lightly masquerading as the typescript spec code (just changed the name from func to function otherwise Go syntax) is a bit surprising.
The text was updated successfully, but these errors were encountered: