-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate validation and handling for recv slash packets #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the refactor getting rid of the getChainIdOrPanic method. But @mpoke really needs to review it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This makes things much easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @smarshall-spitzbart. See my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR separates out validation and handling for slash packets received on the provider. This allows us to separate out the concerns of
No functionality should be changed in this PR, but the refactors are needed to properly implement #462
Note: VSCMatured packet handling is refactored in this PR as well (just adds an explicit handler method). Jehan and I decided it doesn't make sense to have a validate method for VSCMatured packets since there's not a case in which to return an IBC err ack
Linked issues
Closes #414
Type of change
Please delete options that are not relevant.
How was the feature tested?
Other information
Changes in functionality are reserved for #546 and #547
Checklist:
Please delete options that are not relevant.
#<issue>