Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make OTA works for ESP32 #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

secmask
Copy link

@secmask secmask commented Nov 3, 2023

it looks that telegramClient->find get blocking on ESP32, in my OTA update, it always cannot read getFile command properly, and result an error.

Type of change:

make block sendCommand read response like other parts.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Testing:

  • merged with the current development branch (before testing)
  • CI build finished without issues
  • Tested on real hardware (List board here): ESP32-C3, ESP8266
  • Changes are backward compatible

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@secmask secmask mentioned this pull request Nov 3, 2023
@secmask secmask changed the title make request work for ESP32 make OTA works for ESP32 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant