-
Notifications
You must be signed in to change notification settings - Fork 2
AV-68536: complete quickstart code for spring data #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV-68536: complete quickstart code for spring data #34
Conversation
Update AirlineRepository and AirlineService
…sitory annotations.
…r + refactored integration tests
This commit refactors the integration tests in the `RouteIntegrationTest` and `AirlineIntegrationTest` classes to use a dynamic base URI based on the value of the `spring.couchbase.bootstrap-hosts` property. This allows the tests to run against different environments without modifying the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the README has been reviewed.
Recommendations:
- Move the code explanations into the tutorial on Developer Portal
- Adapt the text to be Capella first.
- Check the recommendations from spring boot as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of things needs to change
src/main/java/org/couchbase/quickstart/springdata/repository/AirlineRepository.java
Outdated
Show resolved
Hide resolved
…images, changed javax to jakarta. Used environment variables instead of hardcoding
…irportIntegrationTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few adjusments left
src/main/java/org/couchbase/quickstart/springdata/models/RestResponsePage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/couchbase/quickstart/springdata/models/RestResponsePage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/couchbase/quickstart/springdata/models/RestResponsePage.java
Outdated
Show resolved
Hide resolved
… + api endpoints refactoring similar to python
No description provided.