Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

test: add blob read check #1868

Merged
merged 5 commits into from
Feb 8, 2019
Merged

test: add blob read check #1868

merged 5 commits into from
Feb 8, 2019

Conversation

jayahariv
Copy link
Contributor

  • add read checks
  • add blob constructor from fileURL
  • blob from fileURL was not working, as the file loaded was empty and the exception was not failing. so refactored to make sure that reads the file and checks the code.

* add read checks
* add blob constructor from fileURL
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 75.268% when pulling dd234d0 on test/blobReadTests into e9ab0a4 on master.

:
fix: review comments

* nits: indentation & name
@jayahariv jayahariv merged commit 597ffbf into master Feb 8, 2019
@jayahariv jayahariv deleted the test/blobReadTests branch February 8, 2019 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants