Skip to content

Commit

Permalink
CBG-749 Backport CBG-471 to 2.7.2 - Pre-2.5 _attachment migration (#4528
Browse files Browse the repository at this point in the history 
) (#4535)

* Unit test repro

* Update test

Return hasPre25Attachments bool from revcache for upgrade case

fix _attachment in test

wip

Remove write part of attachment meta (rely on in-memory moving on each read)

Remove debug

Return error instead of panic

Reorder teardown to prevent panics using walrus

Improve comments, extra assertions on doc syncData

Remove unnecessary changes

* Reuse inject/MergeAttachment functions when injecting attachments into bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta

* Update to centralise attachment handling in getRevision

Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>

Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
  • Loading branch information
@bbrks @adamcfraser
bbrks and adamcfraser committed Mar 18, 2020
1 parent 86b88d7 commit 583d2dc
Show file tree
Hide file tree
Showing 5 changed files with 919 additions and 60 deletions.
Loading

0 comments on commit 583d2dc

Please sign in to comment.