CBG-741 - Pre-2.5 _attachment migration #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
force-pushed
the
CBG-741
branch
2 times, most recently
from
0e3215e
to
59bf30b
Compare
adamcfraser
requested changes
Mar 16, 2020
adamcfraser
requested changes
Mar 17, 2020
Return hasPre25Attachments bool from revcache for upgrade case fix _attachment in test wip Remove write part of attachment meta (rely on in-memory moving on each read) Remove debug Return error instead of panic Reorder teardown to prevent panics using walrus Improve comments, extra assertions on doc syncData Remove unnecessary changes
…o bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta
|
Tweaked the approach based on discussion yesterday, and evaluating usages of getRevision to avoid processing _attachments over and over, and doing it in many places. Black arrows are all calls down into getRevision.
|
adamcfraser
approved these changes
Mar 18, 2020
bbrks
added a commit
that referenced
this pull request
Mar 18, 2020
) * Unit test repro * Update test Return hasPre25Attachments bool from revcache for upgrade case fix _attachment in test wip Remove write part of attachment meta (rely on in-memory moving on each read) Remove debug Return error instead of panic Reorder teardown to prevent panics using walrus Improve comments, extra assertions on doc syncData Remove unnecessary changes * Reuse inject/MergeAttachment functions when injecting attachments into bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta * Update to centralise attachment handling in getRevision Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
adamcfraser
added a commit
that referenced
this pull request
Mar 18, 2020
) (#4535) * Unit test repro * Update test Return hasPre25Attachments bool from revcache for upgrade case fix _attachment in test wip Remove write part of attachment meta (rely on in-memory moving on each read) Remove debug Return error instead of panic Reorder teardown to prevent panics using walrus Improve comments, extra assertions on doc syncData Remove unnecessary changes * Reuse inject/MergeAttachment functions when injecting attachments into bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta * Update to centralise attachment handling in getRevision Co-authored-by: Adam Fraser <adam.fraser@couchbase.com> Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs an in-memory migration of pre-2.5 _attachment metadata into syncData on read before storing in revcache. Does not persist this migration back to the bucket.
New Tests:
Integration Tests