CBG-749 Backport CBG-471 to 2.7.2 - Pre-2.5 _attachment migration #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Unit test repro * Update test Return hasPre25Attachments bool from revcache for upgrade case fix _attachment in test wip Remove write part of attachment meta (rely on in-memory moving on each read) Remove debug Return error instead of panic Reorder teardown to prevent panics using walrus Improve comments, extra assertions on doc syncData Remove unnecessary changes * Reuse inject/MergeAttachment functions when injecting attachments into bodyBytes, add new tests to support mixed pre-2.5 and 2.5 meta * Update to centralise attachment handling in getRevision Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
adamcfraser
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4528