Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3718 delta sync pull #3845

Merged
merged 5 commits into from
Dec 6, 2018
Merged

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Dec 3, 2018

No description provided.

rest/blip_sync.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_client_test.go Outdated Show resolved Hide resolved
rest/blip_api_test.go Outdated Show resolved Hide resolved
@bbrks bbrks force-pushed the feature/issue_3718_delta_sync_pull branch from 3977f7c to 846859e Compare December 4, 2018 13:16
<!-- Enterprise edition dependencies -->
<project groups="notdefault,cb_sg_enterprise" name="go-fleecedelta" path="godeps/src/github.com/couchbaselabs/go-fleecedelta" remote="couchbaselabs_private" revision="1277ab2af4e7b861a66aadca51a7f49679f9522f"/>
<project groups="notdefault,cb_sg_enterprise" name="go-diff" path="godeps/src/github.com/sergi/go-diff" remote="couchbasedeps" revision="da645544ed44df016359bd4c0e3dc60ee3a0da43"/>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently these only get pulled when the project is set to sg-accel

We might need to decide if the bootstrap script should take an edition parameter instead?

rest/blip_sync.go Outdated Show resolved Hide resolved
rest/blip_sync.go Outdated Show resolved Hide resolved
rest/blip_sync.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - waiting to merge until we have integration/PR build support for new private repo.

a connecting CBL client replicating over blip.

- Fix BLIP logging

- Initial delta sync pull implementation

- Move deltaSrc to blip message property

- Bump manifest for fleece, improve bliptest client WaitForRev

- Assert that the blip message sent was using deltas in EE and full-body in CE

- Split fleecedelta invocations out into files with EE/CE build flags

- Add notdefault to EE deps in manifest
@bbrks bbrks force-pushed the feature/issue_3718_delta_sync_pull branch from 7573a8b to 77ddd49 Compare December 6, 2018 12:25
@bbrks
Copy link
Member Author

bbrks commented Dec 6, 2018

Rebased onto master and fixed conflict. I've set up the builds for private repos now, so running through pipeline.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 60.759% when pulling 77ddd49 on feature/issue_3718_delta_sync_pull into 0c5d11c on master.

adamcfraser pushed a commit that referenced this pull request Apr 6, 2019
* Remove fallthrough from blipSyncContext.Logf (Backport part of #3845)

* CBG-259 Handle errors from sender.Send to prevent starting goroutines to wait for unsent message responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants