Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport CBG-259 to 2.1.3.1 #4059

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Backport CBG-259 to 2.1.3.1 #4059

merged 2 commits into from
Apr 6, 2019

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Apr 6, 2019

  • CBG-259 Handle errors and propagate upwards from sender.Send to prevent starting goroutines to wait for unsent message responses
  • Remove fallthrough from blipSyncContext.Logf to prevent duplicate logging (Partial backport of change in #3718 delta sync pull #3845)

@bbrks bbrks requested a review from adamcfraser April 6, 2019 13:14
@bbrks bbrks added the review label Apr 6, 2019
@coveralls
Copy link

coveralls commented Apr 6, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 51.787% when pulling 1228e6e on backport/CBG-259-2.1.3.1 into 7143b13 on release/2.1.3.1.

@adamcfraser adamcfraser merged commit 60ebdbe into release/2.1.3.1 Apr 6, 2019
@bbrks bbrks deleted the backport/CBG-259-2.1.3.1 branch April 8, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbrks @coveralls @adamcfraser @pasin