Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the version for gorunner #228

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Updating the version for gorunner #228

merged 1 commit into from
Sep 20, 2024
+1 −0

Conversation

a-atri
Copy link
Collaborator

@a-atri a-atri commented Sep 20, 2024 •
edited
Loading

Jira

  • AV-87193

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code
  • I have made sure that no schema field is marked with both requiresReplace and computed

Further comments

@a-atri a-atri requested review from a team as code owners September 20, 2024 07:13
SaicharanCB
SaicharanCB reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@SaicharanCB SaicharanCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

nishant-tripathy
nishant-tripathy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@nishant-tripathy nishant-tripathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aniket-Kumar-c
aniket-Kumar-c approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@aniket-Kumar-c aniket-Kumar-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-atri a-atri merged commit 8221c32 into main Sep 20, 2024
4 checks passed
Lagher0 added a commit that referenced this pull request Oct 6, 2024
@Lagher0
Merge remote-tracking branch 'origin/main' into AV-82735_add_flush_bu…
01d00bf 
…cket

* origin/main:
  AV-78889 - VNET peering azure (#216)
  Av 87139 fix gorunner version (#232)
  Av 87139 fix gorunner version (#231)
  Av 87139 fix gorunner version (#230)
  AV-87139 fix gorunner version (#229)
  Updating the version for gorunner (#228)
  AV-87077 | handle computed values in acc test (#227)
  [AV-86105] initialized autoexpansion field with null value (#226)
  [AV-86503] Updated the changelog (#221)
  [AV-86224] Generated docs for Terraform V1.3.0 (#220)
  [AV-86845] Deprecate the `configurationType` attribute in the cluster resource (#222)
  Bump github.com/hashicorp/terraform-plugin-go from 0.22.1 to 0.23.0 (#193)
  Bump github.com/hashicorp/terraform-plugin-framework from 1.6.1 to 1.9.0 (#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaicharanCB SaicharanCB SaicharanCB left review comments

@aniket-Kumar-c aniket-Kumar-c aniket-Kumar-c approved these changes

@nishant-tripathy nishant-tripathy nishant-tripathy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-atri @SaicharanCB @nishant-tripathy @aniket-Kumar-c