-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV-66047 Add PR template #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matty271828
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for sorting this!
Will let others have a look before approval, see if they want anything particular on it
matty271828
approved these changes
Oct 31, 2023
Talina06
approved these changes
Oct 31, 2023
matty271828
added a commit
that referenced
this pull request
Nov 2, 2023
…equest * main: [AV-66360] PP Bugs - Make resource object optional (#76) [AV-65775] List APIs - Database Credentials & Buckets Pagination (#74) AV-66047 Add PR template (#67) [AV-65679] List APIs - Users, ApiKeys & Clusters Pagination (#73) [AV-65771] List APIs - Projects pagination (#72) [AV-65452] CREATE bucket with optional fields (#68)
Talina06
added a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> Private Preview Release (#43) This merge commit adds support for the following resources to the Terraform Provider 🎉 Organizations - Read/Import Projects - CRUD/Import Users - CRUD/Import API Keys - CRUD/Import Provisioned Clusters - CRUD/Import Database Credentials - CRUD/Import Buckets - CRUD/Import Scope of Work Completed 📅 - Oct 4 2023 Co-Authors ❤️ - @aniket-Kumar-c @matty271828 @nidhi07kumar @Talina06 --------- Co-authored-by: aniket-Kumar-c <115682403+aniket-Kumar-c@users.noreply.github.com> Co-authored-by: matty271828 <65253959+matty271828@users.noreply.github.com> Co-authored-by: nidhi07kumar <78451190+nidhi07kumar@users.noreply.github.com> Co-authored-by: Talina06 <5362897+Talina06@users.noreply.github.com> Change miv terraform version in readme to 1.5.2 (#53) [AV-65208] Update examples folder (#55) * Update examples folder * Update examples/certificate/README.md Co-authored-by: nidhi07kumar <78451190+nidhi07kumar@users.noreply.github.com> * Update examples/database_credential/terraform.template.tfvars Co-authored-by: nidhi07kumar <78451190+nidhi07kumar@users.noreply.github.com> * [AV-65208] Add godocs for better understanding of access and usage (#56) * Add godocs for better understanding of access and usage * Generate docs * [AV-65208] Datasources for some resources (#57) * Add datasources, rename datasources * Generate docs * Move some values in examples folder to variables * update wording in readme --------- Co-authored-by: nidhi07kumar <78451190+nidhi07kumar@users.noreply.github.com> fix added for various resources creation in main branch removed if match in allowlist and some more fix updated deleted user fixed examples [AV-64572] Code Health - Extract Schema State Validation (#50) This PR extracts state validation which was duplicated between resource states into functions. Additionally, the validation changes will mean that terraform import strings will now be able to provide resourceIds in any order. * Extract resource state validation * Add null strings to validate test cases * Use validation functions for bucket resource * Map IDs to specific resource IDs * Use id attribute for top level resource IDs * Add unit tests for all schema validates * Fix ID key/values in cluster validate state * Remove unused ifmatch from allowlist * Remove use of depracated cluster data * Chnage clusterId key to organizationId * Split import strings on first equals sign This is needed as bucket IDs are suffixed with == * Add comment to explain splitting on first equals * Change error to ErrInvalidImport * Use defined errors in validations Better access example for creating db user (#61) Also adds a changelog [AV-65899] PP Bugs - Move project roles into same array (#64) AV-65056: acceptance test poc for project (#54) Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> [AV-65773] Allowlists Datasource - Pagination (#65) [AV-65452] CREATE bucket with optional fields (#68) [AV-65771] List APIs - Projects pagination (#72) [AV-65679] List APIs - Users, ApiKeys & Clusters Pagination (#73) AV-66047 Add PR template (#67) Merging so we can reap benefits from it soon, thanks riju! [AV-65775] List APIs - Database Credentials & Buckets Pagination (#74) [AV-66360] PP Bugs - Make resource object optional (#76) [AV-63471] User Resource - Update user using patch request (#62) Bump golang.org/x/net from 0.13.0 to 0.17.0 (#51) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/grpc from 1.57.0 to 1.57.1 (#66) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [AV-67060] PP Bugs - Pass in sort by parameter (#83) [AV-64820] App Services Terraform Provider Feature Branch (#84) Co-authored-by: Matty Maclean <matty.maclean@couchbase.com> Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> Co-authored-by: matty271828 <65253959+matty271828@users.noreply.github.com> Co-authored-by: Aniket Kumar <aniket.kumar@couchbase.com> Co-authored-by: aniket-Kumar-c <115682403+aniket-Kumar-c@users.noreply.github.com> Co-authored-by: Priya Rajagopal <rajagp@users.noreply.github.com> [AV-62009] Code Health - Pass in Success Codes to Client (#80) [AV-67237] Code Health - Create Acceptance Test Directory (#87) [AV-65776] App Services List Pagination (#91) [AV-64825] Feature branch for on-demand backups, scheduled backups and restore (#92) Co-authored-by: aniket-Kumar-c <115682403+aniket-Kumar-c@users.noreply.github.com> Co-authored-by: Aniket Kumar <aniket.kumar@couchbase.com> Backup schedule enhancement and readme updates (#94) Co-authored-by: nidhi07kumar <78451190+nidhi07kumar@users.noreply.github.com> Co-authored-by: Nidhi Kumar <nidhi.kumar@couchbase.com> [AV-66756] Code Health - Extract API error handling (#78) [AV-67129] Code Health - Upgrade go to version 1.21 (#97) cluster resources acceptance test added and bugs resolved (#77) Signed-off-by: Aniket Kumar <aniket.kumar@couchbase.com> Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> [AV-67085] Bug Fixes - User creation fails on role creation (#102) [AV-65757] adding organization data source acceptance tests (#96) Co-authored-by: matty271828 <65253959+matty271828@users.noreply.github.com> AV-68277 Create LICENSE (#103) [AV-65764] allowlist_acceptance_tests (#95) [AV-68063] Create Backup & DB Creds should not required optional fields (#101) [AV-67976] CREATE USER should not require optional fields (#99) [AV-65762]Fix allowlist acceptance tests (#107) [AV-65452] Bucket Update: Handle optional fields (#75) [AV-67686] README for backup schedule (#100) [AV-65766] Acceptance Tests AppServices (#98) [AV 65760] additional project acceptance tests (#110) [AV-68397] API Key & Allowlist creation does not need optional fields (#104) [AV-66942] DB Creds | App Services | Backup Schedule Update Optional Fields (#106) Added return where it is missing (#109) Generate changelog, add a Makefile and Dependabot support (#105) [AV-66663] Bug Fixes - Reject organizationOwner with populated resources (#114) Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> require replace added for non editable fields (#116) [AV-65601] DB Creds changes on UI not picked up in terraform db (#112) Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> hanging resource issue is fixed for cluster and added retry logic (#108) [AV-67459] Save expiry time from plan always for allowlist (#117) cluster-acceptance-test-fix (#118) [AV-68914] Bug - Move type outside of generic function (#120) [AV 65759] fix acceptance tests apikeys (#121) [AV-65758] Acceptance Tests - User Resource (#93) Added check for all resource whether the passed attribute is trimmed or not (#122) [AV-65763] Acceptance Tests - Database Credentials (#89) Co-authored-by: nishant-tripathy <nishant.tripathy@couchbase.com> [AV-64396] Security tests for the capella terraform (#115) [AV-68064] examples for list backups (#123) [AV-69062] Update Examples (#124) [AV-69062] Update examples (#125) [Av 65766] accpetance test appservices (#119) Co-authored-by: aniket-Kumar-c <115682403+aniket-Kumar-c@users.noreply.github.com> Co-authored-by: matty271828 <65253959+matty271828@users.noreply.github.com> [AV 65761] fix cluster accpetance tests (#126) Co-authored-by: aniket-Kumar-c <115682403+aniket-Kumar-c@users.noreply.github.com> Co-authored-by: matty271828 <65253959+matty271828@users.noreply.github.com> AV-69070: configuration type is made optional (#127) Docs draft - complete, with all feedback added, and ready to merge. (#111) Co-authored-by: Priya Rajagopal <rajagp@users.noreply.github.com> [AV-69070] Update examples and default pagination limit (#128) Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> Update Docs (#130) Update Docs (#130) Update index.md (#131) Add github actions to release binaries Bump github.com/google/uuid from 1.4.0 to 1.5.0 (#132) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [AV-69447] Updated Readme for IMPORT (#134) Documentation format tweaks (#135) Bump golang.org/x/crypto from 0.16.0 to 0.17.0 (#136) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [AV-69583] Added CONTRIBUTING.md (#137) Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 (#139) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump github.com/hashicorp/terraform-plugin-go from 0.19.1 to 0.20.0 (#138) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump github.com/couchbase/tools-common/functional from 1.1.1 to 1.2.0 (#140) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [AV-70854] Fixed optional fields during cluster creation | Azure & GCP (#141) Fix the cluster version as 7.1 is not supported (#144) Fix jenkins failures cluster version (#146) Bump github.com/hashicorp/terraform-plugin-framework from 1.4.2 to 1.5.0 (#142) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix format issue for regex check (#147) Bump github.com/google/uuid from 1.5.0 to 1.6.0 (#145) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [AV-71279] Support autoexpansion for Azure cluster resource (#143) Bump github.com/hashicorp/terraform-plugin-go from 0.20.0 to 0.21.0 (#148) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AV-72750 Reformat contributing.md (#150) Adding Azure storage auto expansion accpetance tests (#149) Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#160) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AV-70846 Import sample buckets (#156) Update CODEOWNERS (#168) Revert "AV-70846 Import sample buckets" (#169) AV-74846 Updare codeowners to require both teams reviews (#170) Bump github.com/hashicorp/terraform-plugin-framework from 1.5.0 to 1.6.1 (#161) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add request and response structs add schema add datasource add resources set new datasource and resource in provider fix schema format issue refactor datasources remove require replace from schema refactor fix slice updates use schema object in set function update doc string add api response add schema file add datasource add datasource to provider add example add example add api request and response structs add schema add datasource add datasource to provider fix schema add resource fix validation update struct tags and schema add godocs change variable name update typename add validation logic to create function update Create docstring fix error handling change list to set remove optional attribute add warning change to set in resources schema formatting fix lint errors update example formatting fix import formatting update typename update godoc change list to set update example fix import format update typename update godocs change list to set update error messages refactor getAuditLogExport refactor refreshAuditLogExport remove requiresReplace add example format example fix lint errors update example update example with setting disabled user update example dir example Bump github.com/hashicorp/terraform-plugin-testing from 1.6.0 to 1.7.0 (#162) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Talina Shrotriya <5362897+Talina06@users.noreply.github.com> Bump github.com/hashicorp/terraform-plugin-go from 0.21.0 to 0.22.1 (#165) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> change schema update example change http status code due to AV-74746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
This PR adds a PR template to the repo to standardize the PR descriptions.
Maturity Assessment
Area impacted
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
github change :)
Testing
Testing