-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add document on Couler Step Zoo #94
Conversation
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
I think it's good for the first draft 👍. We can modify it when we have more pre-defined steps added into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution! 🎉 👍
Currently, Couler Step Zoo consists of the following pre-defined steps: | ||
|
||
| Name | Description | API | | ||
| ---- | ----------- | --- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step may also need to include input output definitions
import random | ||
|
||
res = "heads" if random.randint(0, 1) == 0 else "tails" | ||
print(res) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return res
?
|
||
* It should be completely implemented using the core [Couler APIs](couler-api-design.md). | ||
* It should expose backend specific configurations instead of hard-coding them. | ||
* It should have a clear set of dependencies that can be easily installed with sufficient instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to specify the dependencies for a new step function? Adding the dependencies in requirements.txt or other ways?
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
What changes were proposed in this pull request?
Add document on Couler Step Zoo. Related issue #67.
cc'ing @couler-proj/couler-team @xinbinhuang @andreyvelich @FogDong @gaocegege @davidhershey @vishnu2kmohan @JPZ13 @inohmonton99 and others who might be interested to take a look and share feedback.
Why are the changes needed?
This document introduces the Couler Step Zoo, which consists of a collection of pre-defined and reusable steps that can
be used directly as part of a workflow defined using Couler.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not applicable.