12 fetching data twice #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably also explains why I couldn't get any data in, maybe a form of rate limiting if your hitting the API twice consequently with the same parameters |
|
Thank you for this PR @jaapterwoerds! The change makes completely sense and it's true we are calling twice the API for every single ticker. What a mistake! Despite that I'm not fully convinced by the retry refactor, especially because sometimes the Yahoo API is responding with 200 on some errors 🤷♂️ and the parser failing is triggering the retry itself. Can you just submit the changes removing the fetching twice in this PR? You can open another one refactoring the retry if you like. |
|
Hi @jrdi, no problem I'll do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the way retries work by using urllib3 Retry mechanism which has as as a sideeffect the looping is not necessary anymore and data will be fetched only once if there are no errrors