This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
[node] Implement JSONAPI operations #1292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelalejandro
added
📦 Node
ebryn
reviewed
Apr 12, 2019
…/node-jsonapi-ops
snario
reviewed
Apr 29, 2019
| @@ -31,6 +31,41 @@ import { | |||
| } from "./methods"; | |||
| import { NODE_EVENTS } from "./types"; | |||
|
|
|||
| // Maps controllers to JSONAPI operations. | |||
| export const controllersToOperations = { | |||
There was a problem hiding this comment.
Why are some ops in a fixed set like get or add but others are strings like getFreeBalanceState?
There was a problem hiding this comment.
Is there an intro to @ebryn/jsonapi-ts with motivation?
| @@ -21,6 +21,7 @@ | |||
| "lint": "lerna run lint --parallel --no-bail", | |||
| "lint:fix": "lerna run lint:fix --parallel --no-bail", | |||
| "run:playground": "lerna run start --parallel --scope=**/playground --scope=**/playground-server --scope=**/dapp-high-roller --scope=**/dapp-tic-tac-toe", | |||
| "run:playground:server": "lerna run start --parallel --scope=**/playground-server", | |||
There was a problem hiding this comment.
Could simply do yarn start from the playground-server package, no?
| const relayedProposalMsg: NodeOperation = { | ||
| meta: { | ||
| from: requestHandler.publicIdentifier, | ||
| requestId: "" |
There was a problem hiding this comment.
Probably outside the scope of this PR but we should discuss needing requestId - from what I've seen so far it's been empty / not referenced at all.
|
Cancelled in favour of JSONRPC. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of what's being discussed in #1250.