This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf19drofxots
requested review from
ebryn,
ldct,
joelalejandro and
snario
as code owners
July 8, 2019 21:53
snario
suggested changes
Jul 8, 2019
packages/contracts/contracts/default-apps/CoinBalanceRefundApp.sol
Outdated
Show resolved
Hide resolved
packages/node/src/methods/app-instance/get-free-balance/controller.ts
Outdated
Show resolved
Hide resolved
packages/node/test/machine/integration/virtual-app-set-state-commitment.spec.ts
Show resolved
Hide resolved
ldct
reviewed
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for depositing ERC20 tokens into a channel.
Mainly, the API for the deposit method has been extended to include an optional parameter:
token
address, allowing the operator to specify which ERC20 token they'd like to deposit into the channel.monorepo/packages/types/src/node.ts
Lines 151 to 156 in 48f820a
An upcoming PR will add support with withdrawals, and another PR after that to add support for using deposited ERC20 tokens to fund apps.