-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL + Powershell support #2
base: master
Are you sure you want to change the base?
Conversation
Hey, I hope to get in contact and perhaps work together on this repository. I'll try and reach out to you in case this doesn't reach you. |
I'm currently in the process of adding PowerShell Remoting Protocol support. I'd really like to get in contact |
I don't know if you're still actively working on this, but can you use a dynamic package for kerberos? pykerberos isn't compatible with Windows. It's suggested to use winkerberos instead. Adding this to def kerberos():
if os.name == 'nt':
return 'winkerberos'
return 'pykerberos >= 1.2.0'
INSTALL_REQUIRES = (
...
kerberos(),
...
) |
I've transferred ownership of my branch to my previous employer since I've built it there. Can you open up a PR here? https://github.com/transceptor-technology/aio-winrm |
Hey
I've added some changes so that this library also does SSL and Powershell commands.
The code for the powershell commands is "borrowed" from pywinrm.
I've also changed the host parsing so that it behaves a bit different. It used to be this:
which would return
'https://1.2.3.4:5985/wsman'
where port 5985 is the http portThat is of course garbage-in-garbage-out.
But I've changed it to this:
which now returns
'https://1.2.3.4:5986/wsman'
where port 5985 is the https portChanging the behaviour allowed me to not force the "user" to provide a transport variable if he already supplied a url.
I've also removed the callbacks from the code examples and API calls. It is better practice to await your results in stead of providing callbacks.
I hope you find the changes useful.