Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL + Powershell support #2

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

SSL + Powershell support #2

wants to merge 19 commits into from

Conversation

obeleh
Copy link

@obeleh obeleh commented Feb 12, 2018

Hey

I've added some changes so that this library also does SSL and Powershell commands.
The code for the powershell commands is "borrowed" from pywinrm.

I've also changed the host parsing so that it behaves a bit different. It used to be this:

host = parse_host('https://1.2.3.4', transport=TranportKind.http)

which would return 'https://1.2.3.4:5985/wsman' where port 5985 is the http port
That is of course garbage-in-garbage-out.

But I've changed it to this:

host = parse_host('https://1.2.3.4', default_transport=TranportKind.http)

which now returns 'https://1.2.3.4:5986/wsman' where port 5985 is the https port

Changing the behaviour allowed me to not force the "user" to provide a transport variable if he already supplied a url.

I've also removed the callbacks from the code examples and API calls. It is better practice to await your results in stead of providing callbacks.

I hope you find the changes useful.

@obeleh
Copy link
Author

obeleh commented Feb 15, 2018

Hey,

I hope to get in contact and perhaps work together on this repository. I'll try and reach out to you in case this doesn't reach you.

@obeleh
Copy link
Author

obeleh commented Mar 2, 2018

I'm currently in the process of adding PowerShell Remoting Protocol support. I'd really like to get in contact

@mattmess1221
Copy link

mattmess1221 commented Aug 14, 2019

I don't know if you're still actively working on this, but can you use a dynamic package for kerberos? pykerberos isn't compatible with Windows. It's suggested to use winkerberos instead.

Adding this to setup.py makes it work out.

def kerberos():
    if os.name == 'nt':
        return 'winkerberos'
    return 'pykerberos >= 1.2.0'


INSTALL_REQUIRES = (
    ...
    kerberos(),
    ...
)

@obeleh
Copy link
Author

obeleh commented Aug 18, 2019

I've transferred ownership of my branch to my previous employer since I've built it there. Can you open up a PR here? https://github.com/transceptor-technology/aio-winrm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants