Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty source tables now cause RDS to error out at runtime; adds fix #234

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Empty source tables now cause RDS to error out at runtime; adds fix #234

merged 1 commit into from
Mar 31, 2016

Conversation

p5k6
Copy link
Contributor

@p5k6 p5k6 commented Mar 29, 2016

add test for if no input files exist (read => empty table); if so, touch a single output file, else split as normal

add test for if no input files exist (read => empty table); if so, to…
96b31b1 
…uch a single output file, else split as normal
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 64.263% when pulling 96b31b1 on p5k6:fix_rds_empty_table into ca7d989 on coursera:develop.

@p5k6 p5k6 mentioned this pull request Mar 29, 2016
Closed
@cliu587
Copy link
Contributor

cliu587 commented Mar 29, 2016

LGTM - thanks for catching this.

@sb2nov sb2nov merged commit 3e90472 into coursera:develop Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p5k6 @coveralls @cliu587 @sb2nov