Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 👷‍♂️ Add commit lint 🔧 🎨 #5

Closed
slimlime opened this issue Dec 4, 2020 · 3 comments · Fixed by #10
Closed

ci: 👷‍♂️ Add commit lint 🔧 🎨 #5

slimlime opened this issue Dec 4, 2020 · 3 comments · Fixed by #10
Assignees
@slimlime
Labels
👷 ci continuous integration 🔧 config build config etc

Comments

@slimlime
Copy link
Contributor

slimlime commented Dec 4, 2020

eslint-ts
prettier maybe
@slimlime
Copy link
Contributor Author

slimlime commented Dec 5, 2020

others eslint-ts
prettier maybe

@slimlime slimlime added 👷 ci continuous integration 📦 dependecies 🔧 config build config etc labels Dec 5, 2020
@slimlime slimlime self-assigned this Dec 5, 2020
@slimlime slimlime changed the title Add linting 🔧 🎨 ci: 👷‍♂️ Add commit lint 🔧 🎨 Dec 5, 2020
@slimlime
Copy link
Contributor Author

slimlime commented Dec 5, 2020

commitlint

slimlime added a commit that referenced this issue Dec 5, 2020
@slimlime
ci(commitlint): add commitlint
2b96403 
Install commitlint to enforce conventinoal commits

#5
slimlime added a commit that referenced this issue Dec 5, 2020
@slimlime
ci(husky): add husky v5.0.4 for commit hook checks
f0df04a 
Unfortunate commercialisation in v5 for private org sponsorship. Free public. Husky v4 free.

Ref #5 husky to hook in the commitlint
slimlime added a commit that referenced this issue Dec 5, 2020
@slimlime
build(husky): add husky commit hooks for commitlint
01e2699 
#5
@slimlime slimlime linked a pull request Dec 5, 2020 that will close this issue
Add commitlint #10
Merged
slimlime added a commit that referenced this issue Dec 5, 2020
@slimlime
Merge pull request #10 from cousinmango/feature/5-commitlint-config-n…
6e5ecd9 
…onfeature

Add commitlint
Resolves #5 
Merge resolve #10 PR?
@slimlime
Copy link
Contributor Author

slimlime commented Dec 5, 2020

o probs not closed until eventually makes into main prod branch

@seant1 seant1 closed this as completed in 6a0e6f5 Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slimlime slimlime

Labels
👷 ci continuous integration 🔧 config build config etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add commitlint cousinmango/big-brain-map
1 participant
@slimlime