fix: order date range picker buttons #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msrioux-coveo
requested review from
GermainBergeron and
FelixBlaisThon
and removed request for
a team
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
GermainBergeron
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fix allows to invert the order of the buttons
ApplyandCancelin the Date Picker inLayout -> Tableof Plasma. TheCancelbutton needs to be on the left of theApplybutton, as shown in the right side of the table below.Link to ticket here : https://coveord.atlassian.net/jira/software/c/projects/UITOOL/boards/926?modal=detail&selectedIssue=UITOOL-8809
Potential Breaking Changes
Acceptance Criteria