Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mantine): add getRowAttributes prop on table #3719

Merged
merged 1 commit into from
May 14, 2024

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented May 10, 2024

Proposed Changes

Added a prop on the table called getRowAttributes. This prop is useful to provide some attributes on the <tr> tag that depend on the row data, for example if you need to disable one row.

Potential Breaking Changes

None

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@gdostie gdostie force-pushed the ADUI-10016/allow-disabling-rows branch 2 times, most recently from 78f6eca to 813bcfc Compare May 10, 2024 20:01
Copy link

@gdostie gdostie marked this pull request as ready for review May 10, 2024 20:41
@gdostie gdostie requested review from a team, toofff and dmgauthier and removed request for a team May 10, 2024 20:41
Copy link
Contributor

@dmgauthier dmgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some kind of quick README on how to use this ?

@gdostie
Copy link
Collaborator Author

gdostie commented May 13, 2024

Should we have some kind of quick README on how to use this ?

You will, in the changelogs of the release. For now we are merging in the branch next

Base automatically changed from ADUI-10014/simplify-table-examples to next May 14, 2024 15:11
@gdostie gdostie merged commit e7bee4f into next May 14, 2024
4 checks passed
@gdostie gdostie deleted the ADUI-10016/allow-disabling-rows branch May 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants