Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: fix typo in HostedInterfaceConditionOperator #600

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix!: fix typo in HostedInterfaceConditionOperator #600

merged 1 commit into from
Jan 12, 2023

Conversation

dguerinCoveo
Copy link
Contributor

Fixed a typo that was added in my previous PR 😬

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@dguerinCoveo dguerinCoveo requested review from a team as code owners January 12, 2023 14:11
ThibodeauJF
ThibodeauJF approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@ThibodeauJF ThibodeauJF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dguerinCoveo dguerinCoveo merged commit c2587f7 into master Jan 12, 2023
@dguerinCoveo dguerinCoveo deleted the fix/SVCINT-2024-typo branch January 12, 2023 15:10
@louis-bompart
Copy link
Contributor

Note: A fix can't be breaking.

louis-bompart pushed a commit that referenced this pull request Jan 12, 2023
@dguerinCoveo @louis-bompart
fix: typo in HostedInterfaceConditionOperator (#600)
c12341e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathiery pathiery pathiery approved these changes

@ThibodeauJF ThibodeauJF ThibodeauJF approved these changes

@paulgerold paulgerold Awaiting requested review from paulgerold paulgerold was automatically assigned from coveo/admin-console

@gdostie gdostie Awaiting requested review from gdostie gdostie was automatically assigned from coveo/admin-console

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dguerinCoveo @louis-bompart @ThibodeauJF @pathiery