Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update IPX definition #624

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix: update IPX definition #624

merged 3 commits into from
Feb 15, 2023

Conversation

dguerinCoveo
Copy link
Contributor

Update the IPX definition based on the latest changes

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@louis-bompart
Copy link
Contributor

louis-bompart commented Feb 13, 2023

A bit confused here: this looks almost like unused code.
Like, there are only interfaces and it's not used apart from being exported.

I reckon this is because as discussed in #597, the feature that those interfaces describe is not ready for production.
I'd suggest either considering all changes relative to the IPX fixes from a conventional commit standpoint, or putting the interface declaration with your logic, and only updating it there when you're finally ready to make the API Public and documented.

@dguerinCoveo dguerinCoveo changed the title feat!: update IPX definition fix: update IPX definition Feb 13, 2023
@dguerinCoveo
Copy link
Contributor Author

dguerinCoveo commented Feb 13, 2023

Yeah the routes are not prod ready yet since they are under a feature flag. I've updated the commit to flag it as non-breaking

@dguerinCoveo dguerinCoveo merged commit 523f02d into master Feb 15, 2023
@dguerinCoveo dguerinCoveo deleted the feat/SVCINT-2033 branch February 15, 2023 13:37
@github-actions
Copy link

🎉 This PR is included in version 40.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants