Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(securityCache): added FilteringMode attribute for SecurityCache.listSecurityProviderIdentities #656

Merged
merged 1 commit into from
Apr 13, 2023
Merged

feat(securityCache): added FilteringMode attribute for SecurityCache.listSecurityProviderIdentities #656

merged 1 commit into from
Apr 13, 2023

Conversation

toofff
Copy link
Member

@toofff toofff commented Apr 12, 2023 •
edited by jira bot
Loading

Acceptance Criteria

Just adding a new filter for SecurityCache.listSecurityProviderIdentities call

Task: CTCORE-9140
Swagger: /rest/organizations/{organizationId}/securitycache/entities/list

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@toofff toofff requested review from a team as code owners April 12, 2023 01:51
@github-actions
Copy link

github-actions bot commented Apr 12, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

btaillon-coveo
btaillon-coveo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@btaillon-coveo btaillon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@toofff toofff merged commit 813c96c into master Apr 13, 2023
@toofff toofff deleted the feature/CTCORE-9140 branch April 13, 2023 20:13
@github-actions
Copy link

🎉 This PR is included in version 42.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memyrand memyrand memyrand left review comments

@btaillon-coveo btaillon-coveo btaillon-coveo approved these changes

@pdoyon-coveo pdoyon-coveo pdoyon-coveo approved these changes

@dmgauthier dmgauthier dmgauthier approved these changes

@elessardCoveo elessardCoveo Awaiting requested review from elessardCoveo elessardCoveo was automatically assigned from coveo/admin-console

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

@karanatcoveo karanatcoveo Awaiting requested review from karanatcoveo

@yhattab-coveo yhattab-coveo Awaiting requested review from yhattab-coveo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toofff @dmgauthier @pdoyon-coveo @btaillon-coveo @memyrand