Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search, facet): add endpoint to search facets #718

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

aboissinot-coveo
Copy link
Contributor

@aboissinot-coveo aboissinot-coveo commented Aug 8, 2023

📖 Description

Add endpoint to search facet values for a given facet.

See the endpoint in Swagger.

🧪 Testing

🎬 Linked platform-client to my local admin-ui instance and plugged the endpoint with the search action of a facet.

⚠️ For the purpose of this test, I didn't make it so the list reflected the API call's results. I only inspected the network tab to make sure the results returned looked good.

Screen.Recording.2023-08-08.at.11.55.54.AM.mov

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@aboissinot-coveo aboissinot-coveo merged commit 6f6a048 into master Aug 9, 2023
6 checks passed
@aboissinot-coveo aboissinot-coveo deleted the ADUI-9062/search-facets branch August 9, 2023 11:50
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 45.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants